Switch to use spawn fore compatibility reasons

Author: yuanchuan

lib/render/screencast.js

@@ -1,5 +1,8 @@
 import { setTimeout } from 'node:timers/promises';
-import { exec } from 'node:child_process';
+import { spawn } from 'node:child_process';
+import { randomUUID } from 'node:crypto';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
 
 export async function screencast(page, options) {
     const { scale, output, selector, windowWidth, windowHeight } = options;
@@ -29,8 +32,12 @@ export async function screencast(page, options) {
         }
     }, selector);
 
+    let pathFile = options.mp4
+        ? join(tmpdir(), randomUUID() + '.webm')
+        : output;
+
     const recorder = await page.screencast({
-        path: output,
+        path: pathFile,
         crop,
     });
 
@@ -39,7 +46,7 @@ export async function screencast(page, options) {
 
     if (options.mp4) {
         try {
-            return await webmToMp4(output);
+            return await webmToMp4(pathFile, output);
         } catch (e) {
             throw e;
         }
@@ -48,14 +55,16 @@ export async function screencast(page, options) {
     return output;
 }
 
-function webmToMp4(input) {
-    const output = input.replace('.webm', '.mp4');
+function webmToMp4(input, output) {
     return new Promise((resolve, reject) => {
-        exec(`echo -y | ffmpeg -i ${input} -c:v copy ${output}`, (err, stdout, stderr) => {
-            if (err) {
-                reject(err);
-            } else {
+        const ffmpeg = spawn('ffmpeg', ['-i', input, '-c:v',  'copy', output]);
+        ffmpeg.stdin.write('y\n');
+        ffmpeg.stdin.end();
+        ffmpeg.on('close', code => {
+            if (code === 0) {
                 resolve(output);
+            } else {
+                reject(new Error(`error: record failed, ffmpeg exited with code ${code}`));
             }
         });
     });