Skip to content

Commit 3f11339

Browse files
author
Jevgeni Koltšin
committed
small fixes to get image update working
1 parent 2214fba commit 3f11339

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/main/java/com/creatubbles/api/CreatubblesAPI.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ public static void main(String[] args) throws IOException {
5555
Creation creation = uploadResponse.creation;
5656
String relativePath = creation.store_dir + "/" + fileName;
5757
new UploadS3ImageRequest(data, relativePath).execute().getResponse();
58-
Image img = new Image();
59-
img.url = relativePath;
58+
creation.url = relativePath;
6059
UpdateCreationResponse updateResponse = new UpdateCreationRequest(response.access_token, creation).execute().getResponse();
6160
System.exit(0);
6261
}

src/main/java/com/creatubbles/api/core/Creation.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ public class Creation {
88
public Image image;
99
public Creator[] creators;
1010
public String store_dir;
11+
public String url;
1112
}

src/main/java/com/creatubbles/api/request/amazon/UploadS3ImageRequest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.creatubbles.api.request.amazon;
22

33
import com.amazonaws.services.s3.AmazonS3;
4+
import com.amazonaws.services.s3.model.CannedAccessControlList;
45
import com.amazonaws.services.s3.model.ObjectMetadata;
56
import com.amazonaws.services.s3.model.PutObjectRequest;
67
import com.amazonaws.services.s3.model.PutObjectResult;
@@ -35,7 +36,8 @@ public CreatubblesRequest<UploadS3ImageResponse> execute() {
3536
AmazonS3 client = S3ClientUtil.getClient();
3637
ObjectMetadata metadata = new ObjectMetadata();
3738
metadata.setContentLength(data.length);
38-
PutObjectRequest putObjectRequest = new PutObjectRequest(S3ClientUtil.AWS_S3_BUCKET_NAME, filePath, new ByteArrayInputStream(data), metadata);
39+
PutObjectRequest putObjectRequest = new PutObjectRequest(S3ClientUtil.AWS_S3_BUCKET_NAME, filePath, new ByteArrayInputStream(data), metadata)
40+
.withCannedAcl(CannedAccessControlList.PublicRead);
3941
client.putObject(putObjectRequest);
4042
return this;
4143
}

src/main/java/com/creatubbles/api/request/creation/UpdateCreationRequest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.creatubbles.api.CreatubblesAPI;
44
import com.creatubbles.api.core.Creation;
55
import com.creatubbles.api.core.CreatubblesRequest;
6-
import com.creatubbles.api.core.Image;
76
import com.creatubbles.api.response.creation.UpdateCreationResponse;
87
import com.creatubbles.api.util.EndPoints;
98
import com.creatubbles.api.util.HttpMethod;
@@ -18,9 +17,8 @@ public class UpdateCreationRequest extends CreatubblesRequest<UpdateCreationResp
1817
public UpdateCreationRequest(String accessToken, Creation creation) {
1918
super(String.format(EndPoints.CREATIONS_BY_ID, creation.id), HttpMethod.PUT, accessToken);
2019
JsonObject jsonObject = new JsonObject();
21-
Image image = creation.image;
22-
if (image != null && image.url != null && !image.url.startsWith("http")) {
23-
image.url = S3ClientUtil.AWS_S3_BASE_URL + image.url;
20+
if (creation.url != null && !creation.url.startsWith("http")) {
21+
creation.url = S3ClientUtil.AWS_S3_BASE_URL + creation.url;
2422
}
2523
jsonObject.add("creation", CreatubblesAPI.GSON.toJsonTree(creation));
2624
setData(jsonObject.toString());

0 commit comments

Comments
 (0)