Fix the performance of some migrations

Author: lukeholder

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fixed a PHP error that occurred when marking an inventory transfer as pending. ([#4267](https://github.com/craftcms/commerce/issues/4267))
+- Improved the performance of migrations when upgrading to 5.x. ([#4277](https://github.com/craftcms/commerce/issues/4277))
 
 ## 5.6.1.1 - 2026-03-27
 

src/migrations/m220912_111800_add_order_total_qty_column.php

@@ -3,8 +3,6 @@
 namespace craft\commerce\migrations;
 
 use craft\db\Migration;
-use craft\db\Query;
-use yii\db\Expression;
 
 /**
  * m220912_111800_add_order_total_qty_column migration.
@@ -19,41 +17,28 @@ public function safeUp(): bool
         if (!$this->db->columnExists('{{%commerce_orders}}', 'totalQty')) {
             $this->addColumn('{{%commerce_orders}}', 'totalQty', $this->integer()->unsigned());
 
-            $sums = (new Query())
-                ->select([new Expression('SUM(qty) as [[totalQty]]'), '[[orderId]]'])
-                ->from('{{%commerce_lineitems}}')
-                ->indexBy('orderId')
-                ->groupBy('[[orderId]]')
-                ->all();
-
-            $idsByQty = [];
-            foreach ($sums as $sum) {
-                if (!isset($idsByQty[$sum['totalQty']])) {
-                    $idsByQty[$sum['totalQty']] = [];
-                }
-
-                $idsByQty[$sum['totalQty']][] = $sum['orderId'];
-            }
-
-            $cases = [];
-            foreach ($idsByQty as $totalQty => $ids) {
-                $cases[] = 'WHEN id IN (' . implode(', ', $ids) . ') THEN ' . $totalQty;
+            if ($this->db->getIsMysql()) {
+                $this->execute('
+                    UPDATE {{%commerce_orders}} o
+                    LEFT JOIN (
+                        SELECT [[orderId]], SUM([[qty]]) AS [[totalQty]]
+                        FROM {{%commerce_lineitems}}
+                        GROUP BY [[orderId]]
+                    ) agg ON agg.[[orderId]] = o.[[id]]
+                    SET o.[[totalQty]] = COALESCE(agg.[[totalQty]], 0)
+                ');
+            } else {
+                $this->execute('
+                    UPDATE {{%commerce_orders}} o
+                    SET [[totalQty]] = COALESCE(agg.[[totalQty]], 0)
+                    FROM (
+                        SELECT [[orderId]], SUM([[qty]]) AS [[totalQty]]
+                        FROM {{%commerce_lineitems}}
+                        GROUP BY [[orderId]]
+                    ) agg
+                    WHERE o.[[id]] = agg.[[orderId]]
+                ');
             }
-
-            if (!empty($cases)) {
-                $batches = array_chunk($cases, 5);
-                foreach ($batches as $batch) {
-                    $this->update(
-                        '{{%commerce_orders}}',
-                        ['totalQty' => new Expression(sprintf('(CASE %s END)', implode(' ', $batch)))],
-                        [],
-                        [],
-                        false,
-                    );
-                }
-            }
-
-            $this->update('{{%commerce_orders}}', ['totalQty' => 0], ['totalQty' => null], [], false);
         }
 
         return true;

src/migrations/m230214_094122_add_total_weight_column_to_orders.php

@@ -4,8 +4,6 @@
 
 use craft\commerce\db\Table;
 use craft\db\Migration;
-use craft\db\Query;
-use yii\db\Expression;
 
 /**
  * m230214_094122_add_total_weight_column_to_orders migration.
@@ -19,43 +17,29 @@ public function safeUp(): bool
     {
         $this->addColumn(Table::ORDERS, 'totalWeight', $this->decimal(14, 4)->defaultValue(0)->unsigned());
 
-        $sums = (new Query())
-            ->select([new Expression('SUM(weight) as [[totalWeight]]'), '[[orderId]]'])
-            ->from(Table::LINEITEMS)
-            ->indexBy('orderId')
-            ->groupBy('[[orderId]]')
-            ->all();
-
-        $idsByWeight = [];
-        foreach ($sums as $sum) {
-            if (!isset($idsByWeight[$sum['totalWeight']])) {
-                $idsByWeight[$sum['totalWeight']] = [];
-            }
-
-            $idsByWeight[$sum['totalWeight']][] = $sum['orderId'];
-        }
-
-        $cases = [];
-        foreach ($idsByWeight as $totalWeight => $ids) {
-            $cases[] = 'WHEN id IN (' . implode(', ', $ids) . ') THEN ' . $totalWeight;
+        if ($this->db->getIsMysql()) {
+            $this->execute('
+                UPDATE ' . Table::ORDERS . ' o
+                LEFT JOIN (
+                    SELECT [[orderId]], SUM([[weight]]) AS [[totalWeight]]
+                    FROM ' . Table::LINEITEMS . '
+                    GROUP BY [[orderId]]
+                ) agg ON agg.[[orderId]] = o.[[id]]
+                SET o.[[totalWeight]] = COALESCE(agg.[[totalWeight]], 0)
+            ');
+        } else {
+            $this->execute('
+                UPDATE ' . Table::ORDERS . ' o
+                SET [[totalWeight]] = COALESCE(agg.[[totalWeight]], 0)
+                FROM (
+                    SELECT [[orderId]], SUM([[weight]]) AS [[totalWeight]]
+                    FROM ' . Table::LINEITEMS . '
+                    GROUP BY [[orderId]]
+                ) agg
+                WHERE o.[[id]] = agg.[[orderId]]
+            ');
         }
 
-        if (!empty($cases)) {
-            $batches = array_chunk($cases, 5);
-            foreach ($batches as $batch) {
-                $this->update(
-                    Table::ORDERS,
-                    ['totalWeight' => new Expression(sprintf('(CASE %s END)', implode(' ', $batch)))],
-                    [],
-                    [],
-                    false,
-                );
-            }
-        }
-
-        $this->update(Table::ORDERS, ['totalWeight' => 0], ['totalWeight' => null], [], false);
-
-
         return true;
     }