Don’t throw execptions when saving a line item or adjustment that doesnt exist.

Author: lukeholder

src/services/LineItems.php

@@ -206,14 +206,15 @@ public function saveLineItem(LineItem $lineItem, bool $runValidation = true): bo
     {
         $isNewLineItem = !$lineItem->id;
 
-        if (!$lineItem->id) {
+        if ($isNewLineItem) {
             $lineItemRecord = new LineItemRecord();
         } else {
             $lineItemRecord = LineItemRecord::findOne($lineItem->id);
 
             if (!$lineItemRecord) {
-                throw new Exception(Craft::t('commerce', 'No line item exists with the ID “{id}”',
-                    ['id' => $lineItem->id]));
+                Craft::info('Line Item ID:'.$lineItem->id.' does not exist and can not be saved.', __METHOD__);
+                return false;
+
             }
         }
 
@@ -226,7 +227,7 @@ public function saveLineItem(LineItem $lineItem, bool $runValidation = true): bo
         }
 
         if ($runValidation && !$lineItem->validate()) {
-            Craft::info('Line item not saved due to validation error.', __METHOD__);
+            Craft::info('Line Item not saved due to validation error(s).', __METHOD__);
             return false;
         }
 

src/services/OrderAdjustments.php

@@ -149,19 +149,21 @@ public function getAllOrderAdjustmentsByOrderId(int $orderId): array
      */
     public function saveOrderAdjustment(OrderAdjustment $orderAdjustment, bool $runValidation = true): bool
     {
-        if ($orderAdjustment->id) {
+        $newAdjustment = !$orderAdjustment->id;
+
+        if ($newAdjustment) {
+            $record = new OrderAdjustmentRecord();
+        } else {
             $record = OrderAdjustmentRecord::findOne($orderAdjustment->id);
 
             if (!$record) {
-                throw new Exception(Craft::t('commerce', 'No order Adjustment exists with the ID “{id}”',
-                    ['id' => $orderAdjustment->id]));
+                Craft::info('Order Adjustment ID:'.$orderAdjustment->id.' does not exist and can not be saved.', __METHOD__);
+                return false;
             }
-        } else {
-            $record = new OrderAdjustmentRecord();
         }
 
         if ($runValidation && !$orderAdjustment->validate()) {
-            Craft::info('Order Adjustment not saved due to validation error.', __METHOD__);
+            Craft::info('Order Adjustment not saved due to validation error(s).', __METHOD__);
             return false;
         }