Merge pull request #4272 from craftcms/nathaniel/com-548-5x-error-thrown-when-marking-inventory-transfer-as-pending

[5.x] Error when marking inventory transfer as pending

Author: lukeholder

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release Notes for Craft Commerce
 
+## Unreleased
+
+- Fixed a PHP error that occurred when marking an inventory transfer as pending. ([#4267](https://github.com/craftcms/commerce/issues/4267))
+
 ## 5.6.1.1 - 2026-03-27
 
 - Fixed a bug where PDF Link Duration didn’t save. ([#4265](https://github.com/craftcms/commerce/issues/4265))

src/models/inventory/UpdateInventoryLevelInTransfer.php

@@ -2,55 +2,28 @@
 
 namespace craft\commerce\models\inventory;
 
-use craft\base\Model;
-use craft\commerce\base\InventoryItemTrait;
-use craft\commerce\base\InventoryLocationTrait;
 use craft\commerce\enums\InventoryTransactionType;
-use craft\commerce\enums\InventoryUpdateQuantityType;
 
 /**
  * Update (Set and Adjust) Inventory Quantity model
  *
  * @since 5.0
  */
-class UpdateInventoryLevelInTransfer extends Model
+class UpdateInventoryLevelInTransfer extends UpdateInventoryLevel
 {
-    use InventoryItemTrait, InventoryLocationTrait;
-
-    /**
-     * The type is the set of InventoryTransactionType values, plus the `onHand` type.
-     * @var string The inventory update type.
-     */
-    public string $type;
-
-    /**
-     * Whether the update should be associated with a transfer.
-     * @var int|null
-     */
-    public ?int $transferId = null;
-
-    /**
-     * @var InventoryUpdateQuantityType The action to perform on the inventory.
-     */
-    public InventoryUpdateQuantityType $updateAction;
+    protected function defineRules(): array
+    {
+        $rules = parent::defineRules();
 
-    /**
-     * @var int The quantity to update.
-     */
-    public int $quantity;
+        // Update the `['type']` rule to only allow incoming
+        foreach ($rules as &$item) {
+            if ($item[0] !== ['type']) {
+                continue;
+            }
 
-    /**
-     * @var string A note about the inventory update.
-     */
-    public string $note = '';
+            $item['range'] = [...InventoryTransactionType::incoming(), 'onHand'];
+        }
 
-    protected function defineRules(): array
-    {
-        return array_merge(parent::defineRules(), [
-            [['updateAction', 'quantity', 'inventoryLocationId', 'inventoryId', 'type'], 'required'],
-            [['note'], 'string'],
-            [['type'], 'in', 'range' => [...InventoryTransactionType::incoming(), 'onHand']],
-            [['updateAction'], 'in', 'range' => InventoryUpdateQuantityType::values()],
-        ]);
+        return $rules;
     }
 }