Skip to content

Commit 508ea8d

Browse files
committed
Show the spinner right away
Resolves #18664
1 parent 0592574 commit 508ea8d

4 files changed

Lines changed: 5 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
- Fixed a bug where the “Max Authors” section setting was visible for Single sections.
1818
- Fixed an exception that would be thrown when attempting to access undefined keys within `craft\fields\data\JsonData` objects from Twig. ([#18656](https://github.com/craftcms/cms/issues/18656))
1919
- Fixed a bug where address cards could be missing their address preview. ([#18632](https://github.com/craftcms/cms/issues/18632))
20+
- Fixed a bug where the Save button’s spinner wouldn’t appear right away when saving a nested element in a slideout. ([#18664](https://github.com/craftcms/cms/discussions/18664))
2021

2122
## 5.9.18 - 2026-03-26
2223

src/web/assets/cp/dist/cp.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/web/assets/cp/dist/cp.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/web/assets/cp/src/js/ElementEditorSlideout.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,10 @@ Craft.ElementEditorSlideout = Craft.CpScreenSlideout.extend(
156156
ev.stopPropagation();
157157
ev.stopImmediatePropagation();
158158

159+
this.showSubmitSpinner();
159160
await this.settings.onBeforeSubmit();
160161
this.elementEditor.handleSubmit(ev);
162+
this.hideSubmitSpinner();
161163
},
162164

163165
handleSubmitError: function (e) {

0 commit comments

Comments
 (0)