More type-related fixes

Author: cowboy

README.md

@@ -138,27 +138,30 @@ Development environment notes:
   to attach the vscode debugger to the running process as well as reload after you've made changes.
 - I've tried to leave the boilerplate files generated by Fusion's `Create script or add-in` relatively untouched, so
   that the code can be as modular as possible. Unused boilerplate has been removed where possible.
-- There are `# type: ignore` comments throughout the code to get
-  [Pylance](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance) to stop complaining. I would
-  rather not need them, but I'm not sure how to improve this. Any advice or PRs that improve type checking would be
-  greatly appreciated.
+- There are many seemingly extraneous `cast()` calls throughout the code to help 
+  [Pylance](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance) understand what's going on, because [many classes in the underlying adsk libraries aren't proper Enums](https://forums.autodesk.com/t5/fusion-api-and-scripts-forum/faulty-enum-types/m-p/12066483).
 - I've been using a `.vscode/settings.json` file that looks like this, but it's gitignored because it constains local
   paths. AFAIK, there's no way to write these paths in a user or operating system agnostic way. Until there's a better
   solution, I recommend creating a throwaway Fusion add-in from the `Scripts and Add-Ins` dialog just to grab those
   paths, then create your own local `.vscode/settings.json` file in this project using the paths it generates. You'll
-  probably also want to add in the `files.exclude` section to hide auto-generated temp files.
+  probably also want to add in the other stuff from here, to be consistent.
 
 ```json
 {
   "python.autoComplete.extraPaths": ["C:/Users/Cowboy/AppData/Roaming/Autodesk/Autodesk Fusion 360/API/Python/defs"],
   "python.analysis.extraPaths": ["C:/Users/Cowboy/AppData/Roaming/Autodesk/Autodesk Fusion 360/API/Python/defs"],
-  "python.defaultInterpreterPath": "C:/Users/Cowboy/AppData/Local/Autodesk/webdeploy/production/2df205e6add6cffdc9b4f8421c671a7d78103826/Python/python.exe",
+  "python.defaultInterpreterPath": "C:/Users/Cowboy/AppData/Local/Autodesk/webdeploy/production/7627f627889be835182cfc345110c3c9f5bc9cc3/Python/python.exe",
   "files.exclude": {
     "**/__pycache__/": true,
     "**/*.py[codz]": true,
     "**/*$py.class": true
-  }
-}
+  },
+  "editor.tabSize": 4,
+  "editor.defaultFormatter": "charliermarsh.ruff",
+  "ruff.lineLength": 160,
+  "python.analysis.typeCheckingMode": "standard",
+  "python.analysis.diagnosticsSource": "Pylance"
+} 
 ```
 
 Files of interest:

lib/generalUtils/debug_utils.py

@@ -1,4 +1,3 @@
-from enum import Enum
 import adsk.core
 import adsk.fusion
 from ..fusionAddInUtils import log

lib/generalUtils/extrude_utils.py

@@ -1,7 +1,7 @@
 import adsk.core
 import adsk.fusion
 from .value_utils import getNormalizedValueInput
-from typing import TypedDict, NotRequired, Unpack
+from typing import TypedDict, NotRequired, Unpack, cast
 
 # Extrude Feature API Sample
 # https://help.autodesk.com/view/fusion360/ENU/?guid=GUID-CB1A2357-C8CD-474D-921E-992CA3621D04
@@ -22,7 +22,7 @@ def extrude(
     name: str,
     **kwargs: Unpack[ExtrudeKwargs],
 ):
-    operation = kwargs.get("operation", adsk.fusion.FeatureOperations.NewBodyFeatureOperation)
+    operation = kwargs.get("operation", cast(adsk.fusion.FeatureOperations, adsk.fusion.FeatureOperations.NewBodyFeatureOperation))
     offsetFrom = kwargs.get("offsetFrom")
 
     profiles = adsk.core.ObjectCollection.create()
@@ -32,9 +32,9 @@ def extrude(
     features = component.features
     extrudeFeatures = features.extrudeFeatures
 
-    extrudeInput = extrudeFeatures.createInput(profiles, operation)  # type: ignore
+    extrudeInput = extrudeFeatures.createInput(profiles, operation)
     extent = adsk.fusion.DistanceExtentDefinition.create(getNormalizedValueInput(height))
-    extrudeInput.setOneSideExtent(extent, adsk.fusion.ExtentDirections.PositiveExtentDirection)  # type: ignore
+    extrudeInput.setOneSideExtent(extent, cast(adsk.fusion.ExtentDirections, adsk.fusion.ExtentDirections.PositiveExtentDirection))
     if offsetFrom:
         extrudeInput.startExtent = adsk.fusion.FromEntityStartDefinition.create(offsetFrom, adsk.core.ValueInput.createByReal(0))
 

lib/generalUtils/sketch_utils.py

@@ -1,7 +1,7 @@
 import adsk.core
 import adsk.fusion
 import math
-from typing import TypedDict, NotRequired, Unpack
+from typing import TypedDict, NotRequired, Unpack, cast
 
 # Sketch Object
 # https://help.autodesk.com/view/fusion360/ENU/?guid=GUID-2367ed6a-0ad1-4c8f-935e-b52738d1ce2b
@@ -137,13 +137,13 @@ def constrainRectangleWidthHeight(
     dimensions.addDistanceDimension(
         lines.item(0).startSketchPoint,
         lines.item(0).endSketchPoint,
-        adsk.fusion.DimensionOrientations.HorizontalDimensionOrientation,  # type: ignore
+        cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.HorizontalDimensionOrientation),
         lineMidpoint(lines.item(0), -labelOffset),
     )
     dimensions.addDistanceDimension(
         lines.item(1).startSketchPoint,
         lines.item(1).endSketchPoint,
-        adsk.fusion.DimensionOrientations.VerticalDimensionOrientation,  # type: ignore
+        cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.VerticalDimensionOrientation),
         lineMidpoint(lines.item(1), labelOffset),
     )
 
@@ -162,12 +162,12 @@ def constrainPointToPoint(
         dimensions.addDistanceDimension(
             referencePoint,
             sketchPoint,
-            adsk.fusion.DimensionOrientations.HorizontalDimensionOrientation,  # type: ignore
+            cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.HorizontalDimensionOrientation),
             midpoint(point(referencePoint.geometry.x, sketchPoint.geometry.y), sketchPoint.geometry),
         )
         dimensions.addDistanceDimension(
             referencePoint,
             sketchPoint,
-            adsk.fusion.DimensionOrientations.VerticalDimensionOrientation,  # type: ignore
+            cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.VerticalDimensionOrientation),
             midpoint(point(sketchPoint.geometry.x, referencePoint.geometry.y), sketchPoint.geometry),
         )

lib/panelUtils/panel_generate.py

@@ -1,5 +1,6 @@
 import adsk.core
 import adsk.fusion
+from typing import cast
 from ..generalUtils.sketch_utils import (
     addPoints,
     constrainPointToPoint,
@@ -114,7 +115,7 @@ def addRefLine(panelLine: adsk.fusion.SketchLine, offset: float):
         dimensions.addDistanceDimension(
             panelLine.startSketchPoint,
             line.startSketchPoint,
-            adsk.fusion.DimensionOrientations.VerticalDimensionOrientation,  # type: ignore
+            cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.VerticalDimensionOrientation),
             midpoint(lineMidpoint(line), lineMidpoint(panelLine)),
         )
         return line
@@ -126,7 +127,7 @@ def addRefLine(panelLine: adsk.fusion.SketchLine, offset: float):
     dimensions.addDistanceDimension(
         topRefLine.startSketchPoint,
         bottomRefLine.startSketchPoint,
-        adsk.fusion.DimensionOrientations.VerticalDimensionOrientation,  # type: ignore
+        cast(adsk.fusion.DimensionOrientations, adsk.fusion.DimensionOrientations.VerticalDimensionOrientation),
         addPoints(
             midpoint(topRefLine.startSketchPoint.geometry, bottomRefLine.startSketchPoint.geometry),
             point(-0.2, 0),
@@ -190,8 +191,8 @@ def addRefLine(panelLine: adsk.fusion.SketchLine, offset: float):
             -opts.supportSolidHeight,
             "Support",
             offsetFrom=body1.faces.item(5 + slotFaceCount),
-            operation=adsk.fusion.FeatureOperations.JoinFeatureOperation,
-        )  # type: ignore
+            operation=cast(adsk.fusion.FeatureOperations, adsk.fusion.FeatureOperations.JoinFeatureOperation),
+        )
     elif opts.supportType == "shell":
         body1 = extrude(component, sketch, [0, 1, 2, 3], -opts.panelHeight, "Panel")
         body = extrude(
@@ -201,8 +202,8 @@ def addRefLine(panelLine: adsk.fusion.SketchLine, offset: float):
             -opts.supportShellHeight,
             "Support Shell",
             offsetFrom=body1.faces.item(5 + slotFaceCount),
-            operation=adsk.fusion.FeatureOperations.JoinFeatureOperation,
-        )  # type: ignore
+            operation=cast(adsk.fusion.FeatureOperations, adsk.fusion.FeatureOperations.JoinFeatureOperation),
+        )
     else:
         body = extrude(component, sketch, [0], -opts.panelHeight, "Panel")
 

lib/panelUtils/panel_inputs.py

@@ -1,5 +1,6 @@
 import adsk.core
 from enum import Enum
+from typing import cast
 
 app = adsk.core.Application.get()
 ui = app.userInterface
@@ -83,7 +84,9 @@ def initializeInputs(self):
         message = 'For more information, <a href="https://github.com/cowboy/ModularSynthPanelGenerator">read the documentation.</a>'
         self.inputs.addTextBoxCommandInput("infoTextBox", "Information", message, 1, True)
 
-        heightDropdown = self.inputs.addDropDownCommandInput("formatType", "Panel format", adsk.core.DropDownStyles.TextListDropDownStyle)  # type: ignore
+        heightDropdown = self.inputs.addDropDownCommandInput(
+            "formatType", "Panel format", cast(adsk.core.DropDownStyles, adsk.core.DropDownStyles.TextListDropDownStyle)
+        )
         for name in self.options.formatNames:
             heightDropdown.listItems.add(name, name == self.options.formatName)
 
@@ -95,14 +98,18 @@ def initializeInputs(self):
             adsk.core.ValueInput.createByReal(self.options.panelHeight),
         )
 
-        anchorPointDropdown = self.inputs.addDropDownCommandInput("anchorPoint", "Anchor point", adsk.core.DropDownStyles.TextListDropDownStyle)  # type: ignore
+        anchorPointDropdown = self.inputs.addDropDownCommandInput(
+            "anchorPoint", "Anchor point", cast(adsk.core.DropDownStyles, adsk.core.DropDownStyles.TextListDropDownStyle)
+        )
         for name in self.options.anchorPointNames:
             anchorPointDropdown.listItems.add(name, name == self.options.anchorPointName)
 
         supportGroup = self.inputs.addGroupCommandInput("supportGroup", "Reinforcement")
         supportGroup.isExpanded = True
 
-        supportTypeDropdown = supportGroup.children.addDropDownCommandInput("supportType", "Type", adsk.core.DropDownStyles.TextListDropDownStyle)  # type: ignore
+        supportTypeDropdown = supportGroup.children.addDropDownCommandInput(
+            "supportType", "Type", cast(adsk.core.DropDownStyles, adsk.core.DropDownStyles.TextListDropDownStyle)
+        )
         for name in self.options.supportTypeNames:
             supportTypeDropdown.listItems.add(name, name == self.options.supportTypeName)