Skip to content

Commit e21032d

Browse files
use correct method to get app actions (#10065)
1 parent f1257bb commit e21032d

2 files changed

Lines changed: 12 additions & 23 deletions

File tree

apps/klaviyo/src/locations/ConfigScreen.tsx

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import {
2121
getEntryKlaviyoFieldMappings,
2222
setEntryKlaviyoFieldMappings,
2323
} from '../utils/field-mappings';
24-
import { getOrgIdForSdk } from '../utils/sdk-helpers';
2524

2625
// Helper to ensure klaviyoFieldMappings entry exists
2726
const ensureKlaviyoFieldMappingsEntry = async (sdk: ConfigAppSDK) => {
@@ -139,7 +138,6 @@ const ConfigScreen = () => {
139138
const [isDisconnecting, setIsDisconnecting] = useState(false);
140139
const popupWindowRef = useRef<Window | null>(null);
141140
const checkWindowIntervalRef = useRef<number | null>(null);
142-
const orgId = getOrgIdForSdk(sdk);
143141

144142
// Check Klaviyo connection status with polling to handle race conditions
145143
const checkKlaviyoStatus = async (
@@ -151,9 +149,9 @@ const ConfigScreen = () => {
151149
for (let attempt = 1; attempt <= maxRetries; attempt++) {
152150
try {
153151
console.log(`Checking Klaviyo connection status (attempt ${attempt}/${maxRetries})...`);
154-
const appActions = await sdk.cma.appAction.getMany({
155-
organizationId: orgId,
156-
appDefinitionId: sdk.ids.app,
152+
const appActions = await sdk.cma.appAction.getManyForEnvironment({
153+
environmentId: sdk.ids.environment,
154+
spaceId: sdk.ids.space,
157155
});
158156

159157
const checkStatusAppAction = appActions.items.find(
@@ -230,9 +228,9 @@ const ConfigScreen = () => {
230228
console.log('oauth:complete');
231229
const appDefinitionId = sdk.ids.app;
232230
// call app action to complete oauth
233-
const appActions = await sdk.cma.appAction.getMany({
234-
organizationId: orgId,
235-
appDefinitionId,
231+
const appActions = await sdk.cma.appAction.getManyForEnvironment({
232+
environmentId: sdk.ids.environment,
233+
spaceId: sdk.ids.space,
236234
});
237235
console.log('appActions', appActions);
238236
const completeOauthAppAction = appActions.items.find(
@@ -283,9 +281,9 @@ const ConfigScreen = () => {
283281
window.addEventListener('message', messageHandler);
284282

285283
try {
286-
const appActions = await sdk.cma.appAction.getMany({
287-
organizationId: orgId,
288-
appDefinitionId: sdk.ids.app,
284+
const appActions = await sdk.cma.appAction.getManyForEnvironment({
285+
environmentId: sdk.ids.environment,
286+
spaceId: sdk.ids.space,
289287
});
290288

291289
const initiateOauthAppAction = appActions.items.find(
@@ -324,9 +322,9 @@ const ConfigScreen = () => {
324322
const handleDisconnect = async () => {
325323
setIsDisconnecting(true);
326324
try {
327-
const appActions = await sdk.cma.appAction.getMany({
328-
organizationId: orgId,
329-
appDefinitionId: sdk.ids.app,
325+
const appActions = await sdk.cma.appAction.getManyForEnvironment({
326+
environmentId: sdk.ids.environment,
327+
spaceId: sdk.ids.space,
330328
});
331329
const disconnectAppAction = appActions.items.find((action) => action.name === 'Disconnect');
332330
await sdk.cma.appActionCall.create(

apps/klaviyo/src/utils/sdk-helpers.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { ConfigAppSDK } from '@contentful/app-sdk';
21
import { logger } from './logger';
32

43
// The key used to store the app definition ID in localStorage
@@ -35,11 +34,3 @@ export const getGlobalSDK = async (retries = MAX_RETRIES): Promise<any | null> =
3534
}, RETRY_DELAY);
3635
});
3736
};
38-
39-
const APP_ORGANIZATION_ID = '5EJGHo8tYJcjnEhYWDxivp';
40-
const APP_DEFINITION_ID = '2x4lsvuxPAGS2UUHwWVYee';
41-
42-
export const getOrgIdForSdk = (sdk: ConfigAppSDK) => {
43-
const isMarketplaceVersion = sdk.ids.app === APP_DEFINITION_ID;
44-
return isMarketplaceVersion ? APP_ORGANIZATION_ID : sdk.ids.organization;
45-
};

0 commit comments

Comments
 (0)