Cleanup

Author: comnik

src/lib.rs

@@ -4,7 +4,7 @@
 //! differential dataflow computations from declaratively specified
 //! programs, without any additional compilation.
 
-// #![forbid(missing_docs)]
+#![forbid(missing_docs)]
 
 #[macro_use]
 extern crate log;

src/plan/graphql_v2.rs

@@ -252,6 +252,8 @@ fn selection_set_to_paths(
 }
 
 impl GraphQl {
+    /// See Implementable::dependencies, as GraphQl v2 can't implement
+    /// Implementable directly.
     pub fn dependencies(&self) -> Dependencies {
         let mut dependencies = Dependencies::none();
 
@@ -262,6 +264,8 @@ impl GraphQl {
         dependencies
     }
 
+    /// See Implementable::implement, as GraphQl v2 can't implement
+    /// Implementable directly.
     pub fn implement<'b, T, I, S>(
         &self,
         nested: &mut Iterative<'b, S, u64>,
@@ -481,9 +485,9 @@ fn pointer_mut<'a>(v: &'a mut JValue, tokens: &[String]) -> &'a mut JValue {
     }
 }
 
-fn parse_index(s: &str) -> Option<usize> {
-    if s.starts_with('+') || (s.starts_with('0') && s.len() != 1) {
-        return None;
-    }
-    s.parse().ok()
-}
+// fn parse_index(s: &str) -> Option<usize> {
+//     if s.starts_with('+') || (s.starts_with('0') && s.len() != 1) {
+//         return None;
+//     }
+//     s.parse().ok()
+// }

src/plan/pull_v2.rs

@@ -14,6 +14,8 @@ use crate::plan::{Dependencies, ImplContext, Implementable, Plan};
 use crate::{Aid, Value, Var};
 use crate::{Relation, ShutdownHandle, VariableMap};
 
+/// A sequence of attributes that uniquely identify a nesting level in
+/// a Pull query.
 pub type PathId = Vec<Aid>;
 
 /// A plan stage for extracting all matching [e a v] tuples for a
@@ -34,6 +36,8 @@ pub struct PullLevel<P: Implementable> {
 }
 
 impl<P: Implementable> PullLevel<P> {
+    /// See Implementable::dependencies, as PullLevel v2 can't
+    /// implement Implementable directly.
     fn dependencies(&self) -> Dependencies {
         let mut dependencies = self.plan.dependencies();
 
@@ -45,6 +49,8 @@ impl<P: Implementable> PullLevel<P> {
         dependencies
     }
 
+    /// See Implementable::implement, as PullLevel v2 can't implement
+    /// Implementable directly.
     fn implement<'b, T, I, S>(
         &self,
         nested: &mut Iterative<'b, S, u64>,
@@ -143,6 +149,8 @@ pub struct PullAll {
 }
 
 impl PullAll {
+    /// See Implementable::dependencies, as PullAll v2 can't implement
+    /// Implementable directly.
     fn dependencies(&self) -> Dependencies {
         let mut dependencies = Dependencies::none();
 
@@ -154,6 +162,8 @@ impl PullAll {
         dependencies
     }
 
+    /// See Implementable::implement, as PullAll v2 can't implement
+    /// Implementable directly.
     fn implement<'b, T, I, S>(
         &self,
         nested: &mut Iterative<'b, S, u64>,
@@ -220,13 +230,17 @@ pub enum Pull {
 }
 
 impl Pull {
+    /// See Implementable::dependencies, as Pull v2 can't implement
+    /// Implementable directly.
     pub fn dependencies(&self) -> Dependencies {
         match self {
             Pull::All(ref pull) => pull.dependencies(),
             Pull::Level(ref pull) => pull.dependencies(),
         }
     }
 
+    /// See Implementable::implement, as Pull v2 can't implement
+    /// Implementable directly.
     pub fn implement<'b, T, I, S>(
         &self,
         nested: &mut Iterative<'b, S, u64>,

src/server/mod.rs

@@ -9,7 +9,7 @@ use std::time::{Duration, Instant};
 use timely::communication::Allocate;
 use timely::dataflow::operators::capture::event::link::EventLink;
 use timely::dataflow::{ProbeHandle, Scope};
-use timely::logging::{BatchLogger, Logger, TimelyEvent};
+use timely::logging::{BatchLogger, TimelyEvent};
 use timely::progress::Timestamp;
 use timely::worker::Worker;
 
@@ -396,6 +396,7 @@ where
         source: Box<dyn Sourceable<S>>,
         scope: &mut S,
     ) -> Result<(), Error> {
+        // use timely::logging::Logger;
         // let timely_logger = scope.log_register().remove("timely");
 
         // let differential_logger = scope.log_register().remove("differential/arrange");