feature(writejson) add jshint, jscs

Author: coderaiser

.jscsrc

@@ -0,0 +1,19 @@
+{
+    "preset": "crockford",
+    "requireSpaceAfterKeywords": false,
+    "requireCapitalizedConstructors": false,
+    "disallowTrailingWhitespace": "ignoreEmptyLines",
+    "disallowTrailingComma": false,
+    "validateIndentation": false,
+    "requireCurlyBraces": false,
+    "requireVarDeclFirst": false,
+    "requireMultipleVarDecl": false,
+    "requireSpacesInAnonymousFunctionExpression": {
+        "beforeOpeningCurlyBrace": true
+    },
+    "excludeFiles": [
+        "node_modules/**",
+        "modules/**",
+        "bower_components/**"
+    ]
+}

.jshintrc

@@ -0,0 +1,20 @@
+{
+    "esnext": true,
+    "unused"  : true,
+    "bitwise" : false,
+    "browser" : true,
+    "devel" : true,
+    "eqeqeq" : true,
+    "jquery" : false,
+    "newcap" : false,
+    "noarg" : true,
+    "node" : true,
+    "noempty" : true,
+    "nonew" : true,
+    "strict" : true,
+    "undef" : true,
+    "evil"  : true,
+    "expr" : true,
+    "quotmark": "single",
+    "validthis": true
+}

.npmignore

@@ -0,0 +1,4 @@
+.jscsrc
+.jshintrc
+.travis.yml
+test

.travis.yml

@@ -4,6 +4,7 @@ node_js:
     - 4
 
 script:
+  - npm run codestyle
   - npm test
 
 notifications:

README.md

@@ -31,11 +31,11 @@ writejson.sync.try('data.json', {hello: 'world'});
 MIT
 
 [NPMIMGURL]:                https://img.shields.io/npm/v/writejson.svg?style=flat
-[BuildStatusIMGURL]:        https://img.shields.io/travis/coderaiser/writejson/master.svg?style=flat
-[DependencyStatusIMGURL]:   https://img.shields.io/gemnasium/coderaiser/writejson.svg?style=flat
+[BuildStatusIMGURL]:        https://img.shields.io/travis/coderaiser/node-writejson/master.svg?style=flat
+[DependencyStatusIMGURL]:   https://img.shields.io/gemnasium/coderaiser/node-writejson.svg?style=flat
 [LicenseIMGURL]:            https://img.shields.io/badge/license-MIT-317BF9.svg?style=flat
 [NPMURL]:                   https://npmjs.org/package/writejson "npm"
-[BuildStatusURL]:           https://travis-ci.org/coderaiser/writejson  "Build Status"
-[DependencyStatusURL]:      https://gemnasium.com/coderaiser/writejson "Dependency Status"
+[BuildStatusURL]:           https://travis-ci.org/coderaiser/node-writejson  "Build Status"
+[DependencyStatusURL]:      https://gemnasium.com/coderaiser/node-writejson "Dependency Status"
 [LicenseURL]:               https://tldrlegal.com/license/mit-license "MIT License"
 

lib/writejson.js

@@ -5,7 +5,7 @@ var fs          = require('fs'),
 
 module.exports = function(name, json, callback) {
     check(name, json);
-    checkCB(callback); 
+    checkCB(callback);
 
     var str,
         error = tryCatch(function() {
@@ -15,7 +15,7 @@ module.exports = function(name, json, callback) {
     if (error)
         callback(error);
     else
-        fs.writeFile(name, str, callback); 
+        fs.writeFile(name, str, callback);
 };
 
 module.exports.sync = sync;
@@ -35,13 +35,12 @@ module.exports.sync.try = function(name, data) {
     return error;
 };
 
-function check(name, json, callback) {
+function check(name, json) {
     if (typeof name !== 'string')
         throw Error('name should be string!');
 
     if (typeof json !== 'object')
         throw Error('json should be object!');
-    
 }
 
 function checkCB(callback) {

package.json

@@ -9,6 +9,9 @@
   },
   "main": "lib/writejson.js",
   "scripts": {
+    "jscs": "jscs --esnext lib test",
+    "jshint": "jshint lib test",
+    "codestyle": "npm-run-all jshint jscs",
     "test": "tape test/*.js"
   },
   "repository": {
@@ -24,6 +27,9 @@
     "try-catch": "~1.0.0"
   },
   "devDependencies": {
+    "jscs": "^2.7.0",
+    "jshint": "^2.8.0",
+    "npm-run-all": "^1.4.0",
     "tape": "^4.2.2"
   }
 }

test/writejson.js

@@ -6,21 +6,21 @@ let fs          = require('fs');
 let test        = require('tape');
 let writejson   = require('..');
 
-let tmp = os.tmpdir();
-let name = path.join(tmp, String(Math.random()));
-let json = {
+const tmp = os.tmpdir();
+const NAME = path.join(tmp, String(Math.random()));
+const json = {
     hello: 'world'
 };
 
 test('writejson: should write json data to file', t => {
-    writejson(name, json, error => {
+    writejson(NAME, json, error => {
         t.notOk(error, 'no write error');
 
-        fs.readFile(name, 'utf8', (error, data) => {
+        fs.readFile(NAME, 'utf8', (error, data) => {
             t.notOk(error, 'no read error');
             t.deepEqual(json, JSON.parse(data), 'data should be equal');
 
-            fs.unlink(name, error => {
+            fs.unlink(NAME, error => {
                 t.notOk(error, 'no remove error');
                 t.end();
             });
@@ -29,7 +29,7 @@ test('writejson: should write json data to file', t => {
 });
 
 test('writejson: no args', t => {
-    t.throws(writejson, /name should be string!/, 'name check');
+    t.throws(writejson, /name should be string!/, 'NAME check');
     t.end();
 });
 
@@ -48,16 +48,16 @@ test('writejson: no callback', t => {
 });
 
 test('writejson.sync: should write json data to file synchonously', t => {
-    writejson.sync(name, json);
-    let data = fs.readFileSync(name, 'utf8');
+    writejson.sync(NAME, json);
+    let data = fs.readFileSync(NAME, 'utf8');
     t.ok(data, 'data should be read');
     t.deepEqual(json, JSON.parse(data), 'data should be equal');
-    fs.unlinkSync(name);
+    fs.unlinkSync(NAME);
     t.end();
 });
 
 test('writejson.sync: no args', t => {
-    t.throws(writejson.sync, /name should be string!/, 'name check');
+    t.throws(writejson.sync, /name should be string!/, 'NAME check');
     t.end();
 });
 
@@ -69,7 +69,7 @@ test('writejson.sync: no json', t => {
 });
 
 test('writejson.sync.try: no args', t => {
-    t.throws(writejson.sync.try, /name should be string!/, 'name check');
+    t.throws(writejson.sync.try, /name should be string!/, 'NAME check');
     t.end();
 });