feature(writejson) es2015-ify

Author: coderaiser

.eslintrc

@@ -0,0 +1,22 @@
+{
+    "env": {
+        "es6": true,
+        "node": true,
+    },
+    "parserOptions": {
+        "ecmaVersion": 2017,
+    },
+    "rules": {
+        "indent": ["error", 4],
+        "semi": "error",
+        "no-console": 0,
+        "no-use-before-define": ["error", "nofunc"]
+    },
+    "extends": [
+        "eslint:recommended",
+        "plugin:node/recommended"
+    ],
+    "plugins": [
+        "node"
+    ]
+}

.eslintrc.test

@@ -0,0 +1,18 @@
+{
+    "env": {
+        "es6": true,
+        "node": true,
+    },
+    "parserOptions": {
+        "ecmaVersion": 2017,
+    },
+    "rules": {
+        "indent": ["error", 4],
+        "semi": "error",
+        "no-console": 0,
+        "no-use-before-define": ["error", "nofunc"]
+    },
+    "extends": [
+        "eslint:recommended",
+    ]
+}

README.md

@@ -16,20 +16,20 @@ To handle formating optional argument `options` could be used according to [JSON
 Asynchonouse write stringified object.
 
 ```js
-var writejson = require('writejson');
+const writejson = require('writejson');
 
-writejson('data.json', {hello: 'world'}, function(error) {
+writejson('data.json', {hello: 'world'}, (error) => {
     if (error)
         console.error(error.message);
 });
 
-var options = {
+const options = {
     replacer: ['hello'],// properties to put in json
     space: 4            // default space count
     eof: true           // default new line at end of file
 };
 
-writejson('data.json', {hello: 'world'}, options, function(error) {
+writejson('data.json', {hello: 'world'}, options, (error) => {
     if (error)
         console.error(error.message);
 });

lib/writejson.js

@@ -1,11 +1,9 @@
 'use strict';
 
-var fs = require('fs');
-var tryCatch = require('try-catch');
+const fs = require('fs');
+const tryCatch = require('try-catch');
 
-module.exports = function(name, json, options, callback) {
-    var str;
-    
+module.exports = (name, json, options, callback) => {
     if (!callback) {
         callback = options;
         options = {};
@@ -14,7 +12,7 @@ module.exports = function(name, json, options, callback) {
     check(name, json, options);
     checkCB(callback);
 
-    str = stringify(json, options);
+    const str = stringify(json, options);
     fs.writeFile(name, str, callback);
 };
 
@@ -27,12 +25,12 @@ function sync(name, data, options) {
     fs.writeFileSync(name, stringify(data, options));
 }
 
-module.exports.sync.try = function(name, data, options) {
+module.exports.sync.try = (name, data, options) => {
     options = options || {};
     check(name, data, options);
 
-    var result = tryCatch(sync, name, data, options);
-    var error = result[0];
+    const result = tryCatch(sync, name, data, options);
+    const error = result[0];
 
     return error;
 };
@@ -48,16 +46,21 @@ function defaultOptions(options) {
 }
 
 function stringify(data, options) {
-    var result;
-    
     defaultOptions(options);
 
-    result = JSON.stringify(data, options.replacer, options.space);
+    const result = JSON.stringify(data, options.replacer, options.space);
+    const eof = options.eof;
 
-    if (options.eof)
-        result += '\n';
+    return maybeAddNewLine(result, {
+        eof,
+    });
+}
+
+function maybeAddNewLine(str, options) {
+    if (!options.eof)
+        return str;
 
-    return result;
+    return `${str}\n`;
 }
 
 function check(name, json, options) {
@@ -66,7 +69,7 @@ function check(name, json, options) {
 
     if (typeof json !== 'object')
         throw Error('json should be object!');
-
+    
     if (typeof options !== 'object')
         throw Error('options should be object!');
 }

package.json

@@ -9,9 +9,9 @@
   },
   "main": "lib/writejson.js",
   "scripts": {
-    "jscs": "jscs --esnext lib test",
-    "jshint": "jshint lib test",
-    "lint": "redrun jshint jscs",
+    "lint": "redrun lint:*",
+    "lint:lib": "eslint lib",
+    "lint:test": "eslint -c .eslintrc.test --no-eslintrc test",
     "test": "tape test/*.js",
     "coverage": "nyc npm test",
     "report": "nyc report --reporter=text-lcov | coveralls"
@@ -30,10 +30,13 @@
   },
   "devDependencies": {
     "coveralls": "^3.0.0",
-    "jscs": "~3.0.3",
-    "jshint": "^2.8.0",
+    "eslint": "^4.19.1",
+    "eslint-plugin-node": "^6.0.1",
     "nyc": "^12.0.2",
     "redrun": "^6.0.0",
     "tape": "^4.2.2"
+  },
+  "engines": {
+    "node": ">=4.0.0"
   }
 }

test/writejson.js

@@ -1,10 +1,10 @@
 'use strict';
 
-let os          = require('os');
-let path        = require('path');
-let fs          = require('fs');
-let test        = require('tape');
-let writejson   = require('..');
+const os = require('os');
+const path = require('path');
+const fs = require('fs');
+const test = require('tape');
+const writejson = require('..');
 
 const tmp = os.tmpdir();
 const NAME = path.join(tmp, String(Math.random()));
@@ -13,7 +13,7 @@ const json = {
     bye: 'sword'
 };
 
-test('writejson: should write json data to file', t => {
+test('writejson: should write json data to file', (t) => {
     writejson(NAME, json, error => {
         t.notOk(error, 'no write error');
 
@@ -29,18 +29,18 @@ test('writejson: should write json data to file', t => {
     });
 });
 
-test('writejson: should write json data to file with options', t => {
-    let result = {
+test('writejson: should write json data to file with options', (t) => {
+    const result = {
         hello: 'world'
     };
 
-    let options = {
+    const options = {
         replacer: ['hello'],
         space: 2,
         eof: false
     };
 
-    let resultStr = JSON.stringify(json, options.replacer, options.space);
+    const resultStr = JSON.stringify(json, options.replacer, options.space);
 
     writejson(NAME, json, options, error => {
         t.notOk(error, 'no write error');
@@ -59,9 +59,8 @@ test('writejson: should write json data to file with options', t => {
     });
 });
 
-test('writejson: should write json data to file with default options', t => {
-    let resultStr = JSON.stringify(json, null, 4);
-    resultStr += '\n';
+test('writejson: should write json data to file with default options', (t) => {
+    const resultStr = JSON.stringify(json, null, 4) + '\n'
 
     writejson(NAME, json, error => {
         t.notOk(error, 'no write error');
@@ -80,74 +79,74 @@ test('writejson: should write json data to file with default options', t => {
     });
 });
 
-test('writejson: write error', t => {
+test('writejson: write error', (t) => {
     writejson('/hello.json', json, error => {
         t.ok(error, 'should return error: ' + error.message);
         t.end();
     });
 });
 
-test('writejson.sync.try: write error', t => {
-    let error = writejson.sync.try('/hello.json', json);
+test('writejson.sync.try: write error', (t) => {
+    const error = writejson.sync.try('/hello.json', json);
 
     t.ok(error, 'should return error: ' + error.message);
     t.end();
 });
 
-test('writejson: no args', t => {
+test('writejson: no args', (t) => {
     t.throws(writejson, /name should be string!/, 'NAME check');
     t.end();
 });
 
-test('writejson: no json', t => {
-    let fn = () => writejson('hello');
+test('writejson: no json', (t) => {
+    const fn = () => writejson('hello');
 
     t.throws(fn, /json should be object!/, 'json check');
     t.end();
 });
 
-test('writejson: options not object', t => {
-    let fn = () => writejson('hello', {}, 'options', () => {});
+test('writejson: options not object', (t) => {
+    const fn = () => writejson('hello', {}, 'options', () => {});
 
     t.throws(fn, /options should be object!/, 'options check');
     t.end();
 });
 
-test('writejson: no callback', t => {
-    let fn = () => writejson('hello', [1,2,3]);
+test('writejson: no callback', (t) => {
+    const fn = () => writejson('hello', [1,2,3]);
 
     t.throws(fn, /callback should be function!/, 'callback check');
     t.end();
 });
 
-test('writejson.sync: should write json data to file synchonously', t => {
+test('writejson.sync: should write json data to file synchonously', (t) => {
     writejson.sync(NAME, json);
-    let data = fs.readFileSync(NAME, 'utf8');
+    const data = fs.readFileSync(NAME, 'utf8');
     t.ok(data, 'data should be read');
     t.deepEqual(json, JSON.parse(data), 'data should be equal');
     fs.unlinkSync(NAME);
     t.end();
 });
 
-test('writejson.sync: no args', t => {
+test('writejson.sync: no args', (t) => {
     t.throws(writejson.sync, /name should be string!/, 'NAME check');
     t.end();
 });
 
-test('writejson.sync: no json', t => {
-    let fn = () => writejson.sync('hello');
+test('writejson.sync: no json', (t) => {
+    const fn = () => writejson.sync('hello');
 
     t.throws(fn, /json should be object!/, 'json check');
     t.end();
 });
 
-test('writejson.sync.try: no args', t => {
+test('writejson.sync.try: no args', (t) => {
     t.throws(writejson.sync.try, /name should be string!/, 'NAME check');
     t.end();
 });
 
-test('writejson.sync.try: no json', t => {
-    let fn = () => writejson.sync.try('hello');
+test('writejson.sync.try: no json', (t) => {
+    const fn = () => writejson.sync.try('hello');
 
     t.throws(fn, /json should be object!/, 'json check');
     t.end();