refactor: simplify shimExecFile by removing type casts and promisify #2288
Annotations
19 errors
|
Lint
Process completed with exit code 1.
|
|
Unit Test (Electron latest)
Process completed with exit code 1.
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes header command:
test/unit/core/cliExec.test.ts#L201
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:201:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes duration flag:
test/unit/core/cliExec.test.ts#L181
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:181:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes url auth flags:
test/unit/core/cliExec.test.ts#L164
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:164:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes global-config auth flags:
test/unit/core/cliExec.test.ts#L147
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:147:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws when old CLI has no version after Coder prefix:
test/unit/core/cliExec.test.ts#L123
AssertionError: expected [Function] to throw error including 'No version found' but got 'Command failed: /home/runner/.npm/_np…'
- Expected
+ Received
- No version found
+ Command failed: /home/runner/.npm/_npx/facb15251ed1dd39/node_modules/electron/dist/electron /tmp/vscode-coder-tests-cliExec/ver-old-noversion.js version --output json
+ unknown flag: --output
❯ test/unit/core/cliExec.test.ts:123:38
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > parses version from JSON output:
src/core/cliExec.ts#L78
SyntaxError: "undefined" is not valid JSON
❯ Module.version src/core/cliExec.ts:78:20
❯ test/unit/core/cliExec.test.ts:78:11
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws when JSON has no version field:
test/unit/core/cliExec.test.ts#L67
AssertionError: expected [Function] to throw error including 'No version found in output' but got '"undefined" is not valid JSON'
Expected: "No version found in output"
Received: ""undefined" is not valid JSON"
❯ test/unit/core/cliExec.test.ts:67:38
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws on invalid JSON output:
test/unit/core/cliExec.test.ts#L62
AssertionError: expected [Function] to throw error including 'Unexpected token' but got '"undefined" is not valid JSON'
Expected: "Unexpected token"
Received: ""undefined" is not valid JSON"
❯ test/unit/core/cliExec.test.ts:62:38
|
|
Unit Test (Electron 37)
Process completed with exit code 1.
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes header command:
test/unit/core/cliExec.test.ts#L201
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:201:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes duration flag:
test/unit/core/cliExec.test.ts#L181
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:181:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes url auth flags:
test/unit/core/cliExec.test.ts#L164
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:164:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > speedtest > passes global-config auth flags:
test/unit/core/cliExec.test.ts#L147
TypeError: Cannot read properties of undefined (reading 'trim')
❯ test/unit/core/cliExec.test.ts:147:24
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws when old CLI has no version after Coder prefix:
test/unit/core/cliExec.test.ts#L123
AssertionError: expected [Function] to throw error including 'No version found' but got 'Command failed: /home/runner/.npm/_np…'
- Expected
+ Received
- No version found
+ Command failed: /home/runner/.npm/_npx/af6988d8083aeab2/node_modules/electron/dist/electron /tmp/vscode-coder-tests-cliExec/ver-old-noversion.js version --output json
+ unknown flag: --output
❯ test/unit/core/cliExec.test.ts:123:38
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > parses version from JSON output:
src/core/cliExec.ts#L78
SyntaxError: "undefined" is not valid JSON
❯ Module.version src/core/cliExec.ts:78:20
❯ test/unit/core/cliExec.test.ts:78:11
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws when JSON has no version field:
test/unit/core/cliExec.test.ts#L67
AssertionError: expected [Function] to throw error including 'No version found in output' but got '"undefined" is not valid JSON'
Expected: "No version found in output"
Received: ""undefined" is not valid JSON"
❯ test/unit/core/cliExec.test.ts:67:38
|
|
[extension] test/unit/core/cliExec.test.ts > cliExec > version > throws on invalid JSON output:
test/unit/core/cliExec.test.ts#L62
AssertionError: expected [Function] to throw error including 'Unexpected token' but got '"undefined" is not valid JSON'
Expected: "Unexpected token"
Received: ""undefined" is not valid JSON"
❯ test/unit/core/cliExec.test.ts:62:38
|