Skip to content

Commit a5bbf3f

Browse files
committed
manually address remaining P3 and note
1 parent cb5b5ce commit a5bbf3f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/screentracker/pty_conversation.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ func (c *PTYConversation) statusLocked() ConversationStatus {
571571
return ConversationStatusChanging
572572
}
573573

574-
// The send loop gates outbound messages on initialPromptReady.
574+
// The send loop gates stableSignal on initialPromptReady.
575575
// Report "changing" until readiness is detected so that Send()
576576
// rejects with ErrMessageValidationChanging instead of blocking
577577
// indefinitely on a stableSignal that will never fire.

lib/screentracker/pty_conversation_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ func TestInitialPromptReadiness(t *testing.T) {
13021302
assert.Equal(t, st.ConversationStatusStable, c.Status())
13031303
})
13041304

1305-
t.Run("no initial prompt - status is changing when readiness never fires", func(t *testing.T) {
1305+
t.Run("ReadyForInitialPrompt always false - status is changing", func(t *testing.T) {
13061306
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
13071307
t.Cleanup(cancel)
13081308
mClock := quartz.NewMock(t)
@@ -1323,7 +1323,7 @@ func TestInitialPromptReadiness(t *testing.T) {
13231323

13241324
advanceFor(ctx, t, mClock, 1*time.Second)
13251325

1326-
// Even without an initial prompt, the send loop gates on
1326+
// Even without an initial prompt, stableSignal gates on
13271327
// initialPromptReady. Status must reflect that Send()
13281328
// would block.
13291329
assert.Equal(t, st.ConversationStatusChanging, c.Status())

0 commit comments

Comments
 (0)