chore: Refactor setup.sh and cronjob.sh scripts

Author: codeperfectplus

setup.sh

@@ -31,7 +31,6 @@ LOCUST_FILE="$EXTRACT_DIR/SystemGuard-*/src/scripts/locustfile.py"
 HOST_URL="http://localhost:5050"
 INSTALLER_SCRIPT='setup.sh'
 
-echo "User: $(whoami)"
 # Create necessary directories
 mkdir -p "$LOG_DIR"
 mkdir -p "$BACKUP_DIR"
@@ -190,7 +189,6 @@ install() {
     ./cronjob.sh
 
     # Install the executable
-    log "Installing executable to /usr/local/bin/systemguard-installer..."
     install_executable
     log "SystemGuard version $VERSION installed successfully!"
 }

src/scripts/cronjob.sh

@@ -1,5 +1,11 @@
 #!/bin/bash
 
+# Function to log messages with timestamp
+log_with_timestamp() {
+    local message="$1"
+    echo "$(date '+%Y-%m-%d %H:%M:%S') - $message"
+}
+
 # Function to add a cron job with error handling
 add_cron_job() {
     # Define log directory and cron job command
@@ -10,24 +16,24 @@ add_cron_job() {
     # Create log directory with error handling
     mkdir -p "$log_dir"
     if [ $? -ne 0 ]; then
-        echo "Error: Failed to create log directory: $log_dir"
+        log_with_timestamp "Error: Failed to create log directory: $log_dir"
         exit 1
     fi
 
     # Verify user retrieval
     if [ -z "$username" ]; then
-        echo "Error: Unable to retrieve current username."
+        log_with_timestamp "Error: Unable to retrieve current username."
         exit 1
     fi
 
     # Add cron job to crontab with error handling
     (crontab -l 2>/dev/null; echo "$cron_job") | crontab -
     if [ $? -ne 0 ]; then
-        echo "Error: Failed to add the cron job to the crontab."
+        log_with_timestamp "Error: Failed to add the cron job to the crontab."
         exit 1
     fi
 
-    echo "Cron job added: $cron_job"
+    log_with_timestamp "Cron job added: $cron_job"
 }
 
 # Call the function to add the cron job