applied code review suggestion on tests and auth config file

Author: sammyskills

src/Config/Auth.php

@@ -383,7 +383,7 @@ public function registerRedirect(): string
      * Returns the URL the user should be redirected to
      * if force_reset identity is set to true.
      */
-    public function forcePasswordResetRedirect()
+    public function forcePasswordResetRedirect(): string
     {
         $url = setting('Auth.redirects')['force_reset'];
 

tests/Authentication/ForcePasswordResetTest.php

@@ -44,15 +44,11 @@ protected function setUp(): void
 
     public function testUserRequiresPasswordReset(): void
     {
-        /**
-         * @phpstan-var User
-         */
+        /** @var User $user */
         $user = fake(UserModel::class);
         $user->createEmailIdentity(['email' => 'foo@example.com', 'password' => 'secret123']);
 
-        /**
-         * @phpstan-var UserIdentityModel
-         */
+        /** @var UserIdentityModel $identity */
         $identity = model(UserIdentityModel::class);
         $identity->set('force_reset', 1);
         $identity->where('user_id', $user->id);
@@ -63,9 +59,7 @@ public function testUserRequiresPasswordReset(): void
 
     public function testForcePasswordResetOnUser(): void
     {
-        /**
-         * @phpstan-var User
-         */
+        /** @var User $user */
         $user = fake(UserModel::class);
         $user->createEmailIdentity(['email' => 'foo@example.com', 'password' => 'secret123']);
         $user->forcePasswordReset();
@@ -75,9 +69,7 @@ public function testForcePasswordResetOnUser(): void
 
     public function testUndoForcePasswordResetOnUser(): void
     {
-        /**
-         * @phpstan-var User
-         */
+        /** @var User $user */
         $user = fake(UserModel::class);
         $user->createEmailIdentity(['email' => 'foo@example.com', 'password' => 'secret123']);
         $user->forcePasswordReset();
@@ -88,9 +80,7 @@ public function testUndoForcePasswordResetOnUser(): void
 
     public function testRequiresPasswordResetRedirect(): void
     {
-        /**
-         * @phpstan-var User
-         */
+        /** @var User $user */
         $user = fake(UserModel::class);
         $user->createEmailIdentity(['email' => 'foo@example.com', 'password' => 'secret123']);
         $user->forcePasswordReset();
@@ -104,22 +94,16 @@ public function testRequiresPasswordResetRedirect(): void
 
     public function testForceGlobalPasswordReset(): void
     {
-        /**
-         * @phpstan-var User
-         */
+        /** @var User $user */
         $user = fake(UserModel::class);
         $user->createEmailIdentity(['email' => 'foo@example.com', 'password' => 'secret123']);
         $this->actingAs($user);
 
-        /**
-         * @phpstan-var Fabricator
-         */
+        /** @var Fabricator $fabricator */
         $fabricator = new Fabricator(UserIdentityModel::class);
         $fabricator->create(50);
 
-        /**
-         * @phpstan-var UserIdentityModel
-         */
+        /** @var UserIdentityModel $identities */
         $identities = model(UserIdentityModel::class);
         $identities->forceGlobalPasswordReset();
 

tests/Unit/UserIdentityModelTest.php

@@ -76,15 +76,11 @@ public function testCreateCodeIdentityThrowsExceptionIfUniqueCodeIsNotGot(): voi
 
     public function testForceMultiplePasswordReset(): void
     {
-        /**
-         * @phpstan-var Fabricator
-         */
+        /** @var Fabricator $fabricator */
         $fabricator = new Fabricator(UserIdentityModel::class);
         $fabricator->create(10);
 
-        /**
-         * @phpstan-var UserIdentityModel
-         */
+        /** @var UserIdentityModel $identities */
         $identities = model(UserIdentityModel::class);
         $result     = $identities->select('user_id')->findAll();
         $userIds    = [];
@@ -95,9 +91,7 @@ public function testForceMultiplePasswordReset(): void
 
         $identities->forceMultiplePasswordReset($userIds);
 
-        /**
-         * @phpstan-var UserModel
-         */
+        /** @var UserModel $users */
         $users      = model(UserModel::class);
         $first_user = $users->findById($userIds[0]);
         $last_user  = $users->findById($userIds[9]);