Fix php 7.4 substr can return false

samsonasik · samsonasik · commit 6fb9594fa668 · 2023-10-10T08:45:29.000+07:00
diff --git a/src/Authentication/Passwords/PwnedValidator.php b/src/Authentication/Passwords/PwnedValidator.php
@@ -35,7 +35,8 @@ public function check(string $password, ?User $user = null): Result
     {
         $hashedPword = strtoupper(sha1($password));
         $rangeHash   = substr($hashedPword, 0, 5);
-        $searchHash  = (string) substr($hashedPword, 5);
+        /** @var string $searchHash */
+        $searchHash = substr($hashedPword, 5);
 
         try {
             $client = Services::curlrequest([

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ public function check(string $password, ?User $user = null): Result`
`35`	`35`	`{`
`36`	`36`	`$hashedPword = strtoupper(sha1($password));`
`37`	`37`	`$rangeHash = substr($hashedPword, 0, 5);`
`38`		`- $searchHash = (string) substr($hashedPword, 5);`
	`38`	`+ /** @var string $searchHash */`
	`39`	`+ $searchHash = substr($hashedPword, 5);`
`39`	`40`
`40`	`41`	`try {`
`41`	`42`	`$client = Services::curlrequest([`