refactor: add LoginController::getEmailRules() and use it

Author: kenjis

src/Controllers/LoginController.php

@@ -65,7 +65,7 @@ protected function getValidationRules(): array
     {
         return setting('Validation.login') ?? [
             //'username' => setting('Validation._username') ?? $this->getUsernameRules(),
-            'email'    => 'required|max_length[254]|valid_email',
+            'email'    => $this->getEmailRules(),
             'password' => 'required',
         ];
     }
@@ -85,6 +85,20 @@ public static function getUsernameRules(): array
         ];
     }
 
+    /**
+     * Returns the validation rules for email
+     *
+     * @return string[]
+     */
+    public static function getEmailRules(): array
+    {
+        return [
+            'required',
+            'max_length[254]',
+            'valid_email',
+        ];
+    }
+
     /**
      * Logs the current user out.
      */

src/Controllers/MagicLinkController.php

@@ -186,12 +186,12 @@ private function recordLoginAttempt(
     /**
      * Returns the rules that should be used for validation.
      *
-     * @return array<string, string>
+     * @return array<string, array<string, string>>
      */
     protected function getValidationRules(): array
     {
         return [
-            'email' => 'required|max_length[254]|valid_email',
+            'email' => LoginController::getEmailRules(),
         ];
     }
 }

src/Controllers/RegisterController.php

@@ -136,10 +136,14 @@ protected function getValidationRules(): array
             $usernameRules,
             ['is_unique[users.username]']
         );
+        $registrationEmailRules = array_merge(
+            LoginController::getEmailRules(),
+            ['is_unique[auth_identities.secret]']
+        );
 
         return setting('Validation.registration') ?? [
             'username'         => $registrationUsernameRules,
-            'email'            => 'required|valid_email|is_unique[auth_identities.secret]',
+            'email'            => $registrationEmailRules,
             'password'         => 'required|strong_password',
             'password_confirm' => 'required|matches[password]',
         ];