clean up config, re-run rector, and set alias to Config\ClassName when lastname is exists in use statements

Author: samsonasik

rector.php

@@ -28,7 +28,6 @@
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
-use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
 use Rector\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector;
 use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
@@ -80,9 +79,6 @@
         JsonThrowOnErrorRector::class,
         StringifyStrNeedlesRector::class,
 
-        // requires php 8
-        RemoveUnusedPromotedPropertyRector::class,
-
         RemoveUnusedPrivateMethodRector::class => [
             // private method called via getPrivateMethodInvoker
             __DIR__ . '/tests/system/Test/ReflectionHelperTest.php',

system/CodeIgniter.php

@@ -29,6 +29,7 @@
 use CodeIgniter\Router\Router;
 use Config\App;
 use Config\Cache;
+use Config\Kint as KintConfig;
 use Config\Services;
 use Exception;
 use Kint;
@@ -258,7 +259,7 @@ protected function initializeKint()
         /**
          * Config\Kint
          */
-        $config = config('Config\Kint');
+        $config = config(KintConfig::class);
 
         Kint::$depth_limit         = $config->maxDepth;
         Kint::$display_called_from = $config->displayCalledFrom;

system/Test/Mock/MockLogger.php

@@ -11,6 +11,8 @@
 
 namespace CodeIgniter\Test\Mock;
 
+use Tests\Support\Log\Handlers\TestHandler;
+
 class MockLogger
 {
     /*
@@ -81,7 +83,7 @@ class MockLogger
      */
     public $handlers = [
         // File Handler
-        'Tests\Support\Log\Handlers\TestHandler' => [
+        TestHandler::class => [
             // The log levels that this handler will handle.
             'handles' => [
                 'critical',

system/Test/bootstrap.php

@@ -15,6 +15,7 @@
 use Config\Autoload;
 use Config\Modules;
 use Config\Paths;
+use Config\Services as ServicesConfig;
 
 error_reporting(E_ALL);
 ini_set('display_errors', '1');
@@ -78,7 +79,7 @@
 
 // Use Config\Services as CodeIgniter\Services
 if (! class_exists('CodeIgniter\Services', false)) {
-    class_alias('Config\Services', 'CodeIgniter\Services');
+    class_alias(ServicesConfig::class, 'CodeIgniter\Services');
 }
 
 // Initialize and register the loader with the SPL autoloader stack.

system/bootstrap.php

@@ -89,7 +89,7 @@
  * files can use the path constants.
  */
 
-if (! class_exists('Config\Autoload', false)) {
+if (! class_exists(Autoload::class, false)) {
     require_once SYSTEMPATH . 'Config/AutoloadConfig.php';
     require_once APPPATH . 'Config/Autoload.php';
     require_once SYSTEMPATH . 'Modules/Modules.php';
@@ -103,7 +103,7 @@
 
 // Use Config\Services as CodeIgniter\Services
 if (! class_exists('CodeIgniter\Services', false)) {
-    class_alias('Config\Services', 'CodeIgniter\Services');
+    class_alias(Services::class, 'CodeIgniter\Services');
 }
 
 // Initialize and register the loader with the SPL autoloader stack.