make default protocol property and test set savePath without protocol

Author: ddevsr

system/Session/Handlers/RedisHandler.php

@@ -24,7 +24,8 @@
  */
 class RedisHandler extends BaseHandler
 {
-    private const DEFAULT_PORT = 6379;
+    private const DEFAULT_PORT     = 6379;
+    private const DEFAULT_PROTOCOL = 'tcp';
 
     /**
      * phpRedis instance
@@ -108,7 +109,7 @@ protected function setSavePath(): void
             }
 
             $this->savePath = [
-                'protocol' => in_array($matches[1], ['tcp', 'tls'], true) ? $matches[1] : 'tcp',
+                'protocol' => in_array($matches[1], ['tcp', 'tls'], true) ? $matches[1] : self::DEFAULT_PROTOCOL,
                 'host'     => $matches[2],
                 'port'     => empty($matches[3]) ? self::DEFAULT_PORT : $matches[3],
                 'password' => preg_match('#auth=([^\s&]+)#', $matches[4], $match) ? $match[1] : null,

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -54,28 +54,39 @@ protected function getInstance($options = [])
         return new RedisHandler(new AppConfig(), $this->userIpAddress);
     }
 
+    public function testSavePathWithoutProtocol()
+    {
+        $handler = $this->getInstance(
+            ['savePath' => '127.0.0.1:6379']
+        );
+
+        $savePath = $this->getPrivateProperty($handler, 'savePath');
+
+        $this->assertSame('tcp', $savePath['protocol']);
+    }
+
     public function testSavePathTLSAuth()
     {
         $handler = $this->getInstance(
-            ['savePath' => 'tls://127.0.0.1:6379?auth=password&timeout=2.5']
+            ['savePath' => 'tls://127.0.0.1:6379?auth=password']
         );
 
         $savePath = $this->getPrivateProperty($handler, 'savePath');
 
+        $this->assertSame('tls', $savePath['protocol']);
         $this->assertSame('password', $savePath['password']);
-        $this->assertSame(2.5, $savePath['timeout']);
     }
 
     public function testSavePathTCPAuth()
     {
         $handler = $this->getInstance(
-            ['savePath' => 'tcp://127.0.0.1:6379?auth=password&timeout=2.5']
+            ['savePath' => 'tcp://127.0.0.1:6379?auth=password']
         );
 
         $savePath = $this->getPrivateProperty($handler, 'savePath');
 
+        $this->assertSame('tcp', $savePath['protocol']);
         $this->assertSame('password', $savePath['password']);
-        $this->assertSame(2.5, $savePath['timeout']);
     }
 
     public function testSavePathTimeoutFloat()