fix: fix incorrect test and support other patterns

Author: kenjis

system/Helpers/html_helper.php

@@ -265,7 +265,7 @@ function link_tag(
 
         $link .= 'rel="' . $rel . '" ';
 
-        if ($type !== '' && $rel !== 'canonical' && $hreflang === '') {
+        if ($type !== '' && $rel !== 'canonical' && $hreflang === '' && ! ($rel === 'alternate' && $media !== '')) {
             $link .= 'type="' . $type . '" ';
         }
 

tests/system/Helpers/HTMLHelperTest.php

@@ -312,11 +312,21 @@ public function testLinkTag()
         $this->assertSame($expected, link_tag($target));
     }
 
-    public function testLinkTagComplete()
+    public function testLinkTagMedia()
     {
-        $target   = 'https://styles.com/css/mystyles.css';
-        $expected = '<link href="https://styles.com/css/mystyles.css" rel="banana" type="fruit" media="VHS" title="Go away" />';
-        $this->assertSame($expected, link_tag($target, 'banana', 'fruit', 'Go away', 'VHS'));
+        $target = 'https://styles.com/css/mystyles.css';
+        $tag    = link_tag($target, 'stylesheet', 'text/css', '', 'print');
+
+        $expected = '<link href="https://styles.com/css/mystyles.css" rel="stylesheet" type="text/css" media="print" />';
+        $this->assertSame($expected, $tag);
+    }
+
+    public function testLinkTagTitle()
+    {
+        $tag = link_tag('default.css', 'stylesheet', 'text/css', 'Default Style');
+
+        $expected = '<link href="http://example.com/default.css" rel="stylesheet" type="text/css" title="Default Style" />';
+        $this->assertSame($expected, $tag);
     }
 
     public function testLinkTagFavicon()
@@ -349,6 +359,18 @@ public function testLinkTagAlternate()
         $this->assertSame($expected, $tag);
     }
 
+    public function testLinkTagArrayAlternate()
+    {
+        $tag = link_tag([
+            'href'  => 'http://sp.example.com/',
+            'rel'   => 'alternate',
+            'media' => 'only screen and (max-width: 640px)',
+        ]);
+
+        $expected = '<link href="http://sp.example.com/" rel="alternate" media="only screen and (max-width: 640px)" />';
+        $this->assertSame($expected, $tag);
+    }
+
     public function testLinkTagCanonical()
     {
         $tag = link_tag('http://www.example.com/', 'canonical');