Merge pull request #6857 from ping-yee/refactor-replace-time-session

refactor: replace time() with Time into whole `Session` class.

Author: kenjis

system/Session/Handlers/FileHandler.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Session\Handlers;
 
+use CodeIgniter\I18n\Time;
 use CodeIgniter\Session\Exceptions\SessionException;
 use Config\App as AppConfig;
 use ReturnTypeWillChange;
@@ -276,7 +277,7 @@ public function gc($max_lifetime)
             return false;
         }
 
-        $ts = time() - $max_lifetime;
+        $ts = Time::now()->getTimestamp() - $max_lifetime;
 
         $pattern = $this->matchIP === true ? '[0-9a-f]{32}' : '';
 

system/Session/Handlers/MemcachedHandler.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Session\Handlers;
 
+use CodeIgniter\I18n\Time;
 use CodeIgniter\Session\Exceptions\SessionException;
 use Config\App as AppConfig;
 use Memcached;
@@ -167,7 +168,7 @@ public function write($id, $data): bool
         }
 
         if (isset($this->lockKey)) {
-            $this->memcached->replace($this->lockKey, time(), 300);
+            $this->memcached->replace($this->lockKey, Time::now()->getTimestamp(), 300);
 
             if ($this->fingerprint !== ($fingerprint = md5($data))) {
                 if ($this->memcached->set($this->keyPrefix . $id, $data, $this->sessionExpiration)) {
@@ -245,7 +246,7 @@ public function gc($max_lifetime)
     protected function lockSession(string $sessionID): bool
     {
         if (isset($this->lockKey)) {
-            return $this->memcached->replace($this->lockKey, time(), 300);
+            return $this->memcached->replace($this->lockKey, Time::now()->getTimestamp(), 300);
         }
 
         $lockKey = $this->keyPrefix . $sessionID . ':lock';
@@ -258,7 +259,7 @@ protected function lockSession(string $sessionID): bool
                 continue;
             }
 
-            if (! $this->memcached->set($lockKey, time(), 300)) {
+            if (! $this->memcached->set($lockKey, Time::now()->getTimestamp(), 300)) {
                 $this->logger->error('Session: Error while trying to obtain lock for ' . $this->keyPrefix . $sessionID);
 
                 return false;

system/Session/Handlers/RedisHandler.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Session\Handlers;
 
+use CodeIgniter\I18n\Time;
 use CodeIgniter\Session\Exceptions\SessionException;
 use Config\App as AppConfig;
 use Redis;
@@ -293,7 +294,7 @@ protected function lockSession(string $sessionID): bool
                 continue;
             }
 
-            if (! $this->redis->setex($lockKey, 300, (string) time())) {
+            if (! $this->redis->setex($lockKey, 300, (string) Time::now()->getTimestamp())) {
                 $this->logger->error('Session: Error while trying to obtain lock for ' . $this->keyPrefix . $sessionID);
 
                 return false;