test: remove dynamic property in ControllerTest

Author: kenjis

tests/_support/Config/Validation.php

@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <admin@codeigniter.com>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Tests\Support\Config;
+
+use Config\Validation as ValidationConfig;
+
+class Validation extends ValidationConfig
+{
+    public $signup = [
+        'username' => 'required',
+    ];
+    public $signup_errors = [
+        'username' => [
+            'required' => 'You must choose a username.',
+        ],
+    ];
+}

tests/system/ControllerTest.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter;
 
+use CodeIgniter\Config\Factories;
 use CodeIgniter\HTTP\IncomingRequest;
 use CodeIgniter\HTTP\Request;
 use CodeIgniter\HTTP\Response;
@@ -21,6 +22,7 @@
 use Config\App;
 use Config\Services;
 use Psr\Log\LoggerInterface;
+use Tests\Support\Config\Validation;
 
 /**
  * Exercise our core Controller class.
@@ -118,15 +120,8 @@ public function testValidateWithStringRulesNotFound()
 
     public function testValidateWithStringRulesFoundReadMessagesFromValidationConfig()
     {
-        $validation         = config('Validation');
-        $validation->signup = [
-            'username' => 'required',
-        ];
-        $validation->signup_errors = [
-            'username' => [
-                'required' => 'You must choose a username.',
-            ],
-        ];
+        $validation = new Validation();
+        Factories::injectMock('config', 'Validation', $validation);
 
         // make sure we can instantiate one
         $this->controller = new Controller();
@@ -139,10 +134,8 @@ public function testValidateWithStringRulesFoundReadMessagesFromValidationConfig
 
     public function testValidateWithStringRulesFoundUseMessagesParameter()
     {
-        $validation         = config('Validation');
-        $validation->signup = [
-            'username' => 'required',
-        ];
+        $validation = new Validation();
+        Factories::injectMock('config', 'Validation', $validation);
 
         // make sure we can instantiate one
         $this->controller = new Controller();