refactor: move Config\App::$CURLRequestShareOptions to Config\CURLRequest::$shareOptions

Author: kenjis

app/Config/App.php

@@ -461,15 +461,4 @@ class App extends BaseConfig
      * @var bool
      */
     public $CSPEnabled = false;
-
-    /**
-     * --------------------------------------------------------------------------
-     * CURLRequest Share Options
-     * --------------------------------------------------------------------------
-     *
-     * Whether share options between requests or not.
-     *
-     * @var bool
-     */
-    public $CURLRequestShareOptions = true;
 }

app/Config/CURLRequest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Config;
+
+use CodeIgniter\Config\BaseConfig;
+
+class CURLRequest extends BaseConfig
+{
+    /**
+     * --------------------------------------------------------------------------
+     * CURLRequest Share Options
+     * --------------------------------------------------------------------------
+     *
+     * Whether share options between requests or not.
+     *
+     * @var bool
+     */
+    public $shareOptions = true;
+}

system/HTTP/CURLRequest.php

@@ -13,6 +13,7 @@
 
 use CodeIgniter\HTTP\Exceptions\HTTPException;
 use Config\App;
+use Config\CURLRequest as ConfigCURLRequest;
 use InvalidArgumentException;
 
 /**
@@ -116,9 +117,12 @@ public function __construct(App $config, URI $uri, ?ResponseInterface $response
         $this->response       = $response;
         $this->baseURI        = $uri->useRawQueryString();
         $this->defaultOptions = $options;
-        $this->config         = $this->defaultConfig;
-        $this->shareOptions   = $config->CURLRequestShareOptions ?? true;
 
+        /** @var ConfigCURLRequest|null $configCURLRequest */
+        $configCURLRequest  = config('CURLRequest');
+        $this->shareOptions = $configCURLRequest->shareOptions ?? true;
+
+        $this->config = $this->defaultConfig;
         $this->parseOptions($options);
     }
 

tests/system/HTTP/CURLRequestDoNotShareOptionsTest.php

@@ -11,11 +11,13 @@
 
 namespace CodeIgniter\HTTP;
 
+use CodeIgniter\Config\Factories;
 use CodeIgniter\Config\Services;
 use CodeIgniter\HTTP\Exceptions\HTTPException;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\Mock\MockCURLRequest;
 use Config\App;
+use Config\CURLRequest as ConfigCURLRequest;
 use CURLFile;
 
 /**
@@ -38,9 +40,12 @@ protected function setUp(): void
 
     protected function getRequest(array $options = [])
     {
-        $uri                          = isset($options['base_uri']) ? new URI($options['base_uri']) : new URI();
-        $app                          = new App();
-        $app->CURLRequestShareOptions = false;
+        $uri = isset($options['base_uri']) ? new URI($options['base_uri']) : new URI();
+        $app = new App();
+
+        $config               = new ConfigCURLRequest();
+        $config->shareOptions = false;
+        Factories::injectMock('config', 'CURLRequest', $config);
 
         return new MockCURLRequest(($app), $uri, new Response($app), $options);
     }

tests/system/HTTP/CURLRequestTest.php

@@ -11,11 +11,13 @@
 
 namespace CodeIgniter\HTTP;
 
+use CodeIgniter\Config\Factories;
 use CodeIgniter\Config\Services;
 use CodeIgniter\HTTP\Exceptions\HTTPException;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\Mock\MockCURLRequest;
 use Config\App;
+use Config\CURLRequest as ConfigCURLRequest;
 use CURLFile;
 
 /**
@@ -38,9 +40,12 @@ protected function setUp(): void
 
     protected function getRequest(array $options = [])
     {
-        $uri                          = isset($options['base_uri']) ? new URI($options['base_uri']) : new URI();
-        $app                          = new App();
-        $app->CURLRequestShareOptions = true;
+        $uri = isset($options['base_uri']) ? new URI($options['base_uri']) : new URI();
+        $app = new App();
+
+        $config               = new ConfigCURLRequest();
+        $config->shareOptions = true;
+        Factories::injectMock('config', 'CURLRequest', $config);
 
         return new MockCURLRequest(($app), $uri, new Response($app), $options);
     }