Merge pull request #7336 from kenjis/fix-random-string-numeric

fix: random_string() numeric

Author: kenjis

system/Helpers/text_helper.php

@@ -543,7 +543,6 @@ function random_string(string $type = 'alnum', int $len = 8): string
     {
         switch ($type) {
             case 'alnum':
-            case 'numeric':
             case 'nozero':
             case 'alpha':
                 switch ($type) {
@@ -555,17 +554,19 @@ function random_string(string $type = 'alnum', int $len = 8): string
                         $pool = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
                         break;
 
-                    case 'numeric':
-                        $pool = '0123456789';
-                        break;
-
                     case 'nozero':
                         $pool = '123456789';
                         break;
                 }
 
                 return substr(str_shuffle(str_repeat($pool, (int) ceil($len / strlen($pool)))), 0, $len);
 
+            case 'numeric':
+                $max  = 10 ** $len - 1;
+                $rand = random_int(0, $max);
+
+                return sprintf('%0' . $len . 'd', $rand);
+
             case 'md5':
                 return md5(uniqid((string) mt_rand(), true));
 

user_guide_src/source/changelogs/v4.3.3.rst

@@ -13,6 +13,7 @@ SECURITY
 ********
 
 - **Email:** Added missing TLS 1.3 support.
+- **Text Helper:** The :php:func:`random_string()` type **numeric** is now cryptographically secure.
 
 BREAKING
 ********

user_guide_src/source/helpers/text_helper.rst

@@ -30,7 +30,7 @@ The following functions are available:
     Generates a random string based on the type and length you specify.
     Useful for creating passwords or generating random hashes.
 
-    .. warning:: Except for type **crypto**, no cryptographically secure
+    .. warning:: Except for type **numeric** and **crypto**, no cryptographically secure
         strings are generated. Therefore, it must not be used for cryptographic
         purposes or purposes that requires return values to be unguessable.
 
@@ -49,6 +49,9 @@ The following functions are available:
     .. note:: When you use **crypto**, you must set an even number to the second parameter.
         Since v4.2.2, if you set an odd number, ``InvalidArgumentException`` will be thrown.
 
+    .. note:: Since v4.3.3, **numeric** uses ``random_int()``. In the previous
+        versions, it used ``str_shuffle()`` that is not cryptographically secure.
+
     Usage example:
 
     .. literalinclude:: text_helper/002.php