fix $tableName = null

Author: sclubricants

system/Database/BaseConnection.php

@@ -1604,11 +1604,11 @@ abstract public function insertID();
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      *
      * @return false|string
      */
-    abstract protected function _listTables(bool $constrainByPrefix = false, string $tableName = '');
+    abstract protected function _listTables(bool $constrainByPrefix = false, ?string $tableName = null);
 
     /**
      * Generates a platform-specific query string so that the column names can be fetched.

system/Database/MySQLi/Connection.php

@@ -369,13 +369,13 @@ public function escapeLikeStringDirect($str)
      * Generates the SQL for listing tables in a platform-dependent manner.
      * Uses escapeLikeStringDirect().
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $prefixLimit = false, string $tableName = ''): string
+    protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
     {
         $sql = 'SHOW TABLES FROM ' . $this->escapeIdentifiers($this->database);
 
-        if (! empty($tableName)) {
+        if ($tableName !== null) {
             return $sql . ' LIKE ' . $this->escape($tableName);
         }
 

system/Database/OCI8/Connection.php

@@ -243,13 +243,13 @@ public function affectedRows(): int
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $prefixLimit = false, string $tableName = ''): string
+    protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
     {
         $sql = 'SELECT "TABLE_NAME" FROM "USER_TABLES"';
 
-        if (! empty($tableName)) {
+        if ($tableName !== null) {
             return $sql . ' WHERE "TABLE_NAME" LIKE ' . $this->escape($tableName);
         }
 

system/Database/Postgre/Connection.php

@@ -205,13 +205,13 @@ protected function _escapeString(string $str): string
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $prefixLimit = false, string $tableName = ''): string
+    protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
     {
         $sql = 'SELECT "table_name" FROM "information_schema"."tables" WHERE "table_schema" = \'' . $this->schema . "'";
 
-        if (! empty($tableName)) {
+        if ($tableName !== null) {
             return $sql . ' AND "table_name" LIKE ' . $this->escape($tableName);
         }
 

system/Database/SQLSRV/Connection.php

@@ -184,16 +184,16 @@ public function insertID(): int
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $prefixLimit = false, string $tableName = ''): string
+    protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
     {
         $sql = 'SELECT [TABLE_NAME] AS "name"'
             . ' FROM [INFORMATION_SCHEMA].[TABLES] '
             . ' WHERE '
             . " [TABLE_SCHEMA] = '" . $this->schema . "'    ";
 
-        if (! empty($tableName)) {
+        if ($tableName !== null) {
             return $sql .= ' AND [TABLE_NAME] LIKE ' . $this->escape($tableName);
         }
 

system/Database/SQLite3/Connection.php

@@ -161,11 +161,11 @@ protected function _escapeString(string $str): string
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $prefixLimit = false, string $tableName = ''): string
+    protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
     {
-        if (! empty($tableName)) {
+        if ($tableName !== null) {
             return 'SELECT "NAME" FROM "SQLITE_MASTER" WHERE "TYPE" = \'table\''
                    . ' AND "NAME" NOT LIKE \'sqlite!_%\' ESCAPE \'!\''
                    . ' AND "NAME" LIKE ' . $this->escape($tableName);

system/Test/Mock/MockConnection.php

@@ -180,9 +180,9 @@ public function insertID(): int
     /**
      * Generates the SQL for listing tables in a platform-dependent manner.
      *
-     * @param string $tableName If $tableName is provided will return only this table if exists.
+     * @param null|string $tableName If $tableName is provided will return only this table if exists.
      */
-    protected function _listTables(bool $constrainByPrefix = false, string $tableName = ''): string
+    protected function _listTables(bool $constrainByPrefix = false, ?string $tableName = null): string
     {
         return '';
     }