Merge pull request #7760 from kenjis/refactor-model-insert-noAutoIncrement

refactor: remove Model::$tempPrimaryKeyValue

Author: kenjis

system/BaseModel.php

@@ -760,7 +760,7 @@ public function insert($data = null, bool $returnID = true)
 
         // Must be called first, so we don't
         // strip out created_at values.
-        $data = $this->doProtectFields($data);
+        $data = $this->doProtectFieldsForInsert($data);
 
         // doProtectFields() can further remove elements from
         // $data so we need to check for empty dataset again

system/Model.php

@@ -129,13 +129,6 @@ class Model extends BaseModel
      */
     protected $escape = [];
 
-    /**
-     * Primary Key value when inserting and useAutoIncrement is false.
-     *
-     * @var int|string|null
-     */
-    private $tempPrimaryKeyValue;
-
     /**
      * Builder method names that should not be used in the Model.
      *
@@ -281,13 +274,6 @@ protected function doInsert(array $data)
         $escape       = $this->escape;
         $this->escape = [];
 
-        // If $useAutoIncrement is false, add the primary key data.
-        if ($this->useAutoIncrement === false && $this->tempPrimaryKeyValue !== null) {
-            $data[$this->primaryKey] = $this->tempPrimaryKeyValue;
-
-            $this->tempPrimaryKeyValue = null;
-        }
-
         // Require non-empty primaryKey when
         // not using auto-increment feature
         if (! $this->useAutoIncrement && empty($data[$this->primaryKey])) {
@@ -720,14 +706,6 @@ public function insert($data = null, bool $returnID = true)
             }
         }
 
-        if ($this->useAutoIncrement === false) {
-            if (is_array($data) && isset($data[$this->primaryKey])) {
-                $this->tempPrimaryKeyValue = $data[$this->primaryKey];
-            } elseif (is_object($data) && isset($data->{$this->primaryKey})) {
-                $this->tempPrimaryKeyValue = $data->{$this->primaryKey};
-            }
-        }
-
         $this->escape   = $this->tempData['escape'] ?? [];
         $this->tempData = [];