Clean up a few things

sclubricants · sclubricants · commit e3fd3795eb9c · 2022-12-08T10:29:52.000-08:00
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -2084,13 +2084,12 @@ public function onConstraint($set)
     }
 
     /**
-     * Sets data source as a query for insert/update/upsert
+     * Sets data source as a query for insertBatch()/updateBatch()/upsertBatch()/deleteBatch()
      *
      * @param BaseBuilder|RawSql $query
-     * @param string             $alias
      * @param array|string|null  $columns an array or comma delimited string of columns
      */
-    public function setQueryAsData($query, $alias = null, $columns = null): BaseBuilder
+    public function setQueryAsData($query, ?string $alias = null, $columns = null): BaseBuilder
     {
         if (is_string($query)) {
             throw new InvalidArgumentException('$query parameter must be BaseBuilder or RawSql class.');

Original file line number	Diff line number	Diff line change
`@@ -2084,13 +2084,12 @@ public function onConstraint($set)`
`2084`	`2084`	`}`
`2085`	`2085`
`2086`	`2086`	`/**`
`2087`		`- * Sets data source as a query for insert/update/upsert`
	`2087`	`+ * Sets data source as a query for insertBatch()/updateBatch()/upsertBatch()/deleteBatch()`
`2088`	`2088`	`*`
`2089`	`2089`	`* @param BaseBuilder\|RawSql $query`
`2090`		`- * @param string $alias`
`2091`	`2090`	`* @param array\|string\|null $columns an array or comma delimited string of columns`
`2092`	`2091`	`*/`
`2093`		`- public function setQueryAsData($query, $alias = null, $columns = null): BaseBuilder`
	`2092`	`+ public function setQueryAsData($query, ?string $alias = null, $columns = null): BaseBuilder`
`2094`	`2093`	`{`
`2095`	`2094`	`if (is_string($query)) {`
`2096`	`2095`	`throw new InvalidArgumentException('$query parameter must be BaseBuilder or RawSql class.');`