refactor: replace empty()

Author: kenjis

app/Config/Kint.php

@@ -27,7 +27,7 @@ class Kint extends BaseConfig
     */
 
     /**
-     * @var list<class-string<ConstructablePluginInterface>|ConstructablePluginInterface>
+     * @var list<class-string<ConstructablePluginInterface>|ConstructablePluginInterface>|null
      */
     public $plugins;
 
@@ -45,12 +45,12 @@ class Kint extends BaseConfig
     public int $richSort     = AbstractRenderer::SORT_FULL;
 
     /**
-     * @var array<string, class-string<ValuePluginInterface>>
+     * @var array<string, class-string<ValuePluginInterface>>|null
      */
     public $richObjectPlugins;
 
     /**
-     * @var array<string, class-string<TabPluginInterface>>
+     * @var array<string, class-string<TabPluginInterface>>|null
      */
     public $richTabPlugins;
 

system/CodeIgniter.php

@@ -108,7 +108,7 @@ class CodeIgniter
     /**
      * Controller to use.
      *
-     * @var (Closure(mixed...): ResponseInterface|string)|string
+     * @var (Closure(mixed...): ResponseInterface|string)|string|null
      */
     protected $controller;
 
@@ -138,7 +138,7 @@ class CodeIgniter
     /**
      * Request path to use.
      *
-     * @var string
+     * @var string|null
      *
      * @deprecated No longer used.
      */
@@ -302,7 +302,7 @@ private function configureKint(): void
         Kint::$display_called_from = $config->displayCalledFrom;
         Kint::$expanded            = $config->expanded;
 
-        if (! empty($config->plugins) && is_array($config->plugins)) {
+        if (isset($config->plugins) && is_array($config->plugins)) {
             Kint::$plugins = $config->plugins;
         }
 
@@ -315,10 +315,10 @@ private function configureKint(): void
         RichRenderer::$theme  = $config->richTheme;
         RichRenderer::$folder = $config->richFolder;
         RichRenderer::$sort   = $config->richSort;
-        if (! empty($config->richObjectPlugins) && is_array($config->richObjectPlugins)) {
+        if (isset($config->richObjectPlugins) && is_array($config->richObjectPlugins)) {
             RichRenderer::$value_plugins = $config->richObjectPlugins;
         }
-        if (! empty($config->richTabPlugins) && is_array($config->richTabPlugins)) {
+        if (isset($config->richTabPlugins) && is_array($config->richTabPlugins)) {
             RichRenderer::$tab_plugins = $config->richTabPlugins;
         }
 
@@ -848,7 +848,7 @@ protected function tryToRouteIt(?RouteCollectionInterface $routes = null)
      */
     protected function determinePath()
     {
-        if (! empty($this->path)) {
+        if (isset($this->path)) {
             return $this->path;
         }
 
@@ -892,7 +892,7 @@ protected function startController()
         }
 
         // No controller specified - we don't know what to do now.
-        if (empty($this->controller)) {
+        if (! isset($this->controller)) {
             throw PageNotFoundException::forEmptyController();
         }
 
@@ -1091,7 +1091,7 @@ public function spoofRequestMethod()
 
         $method = $this->request->getPost('_method');
 
-        if (empty($method)) {
+        if ($method === null) {
             return;
         }
 

system/View/Table.php

@@ -217,7 +217,7 @@ public function addRow()
     {
         $tmpRow = $this->_prepArgs(func_get_args());
 
-        if ($this->syncRowsWithHeading && ! empty($this->heading)) {
+        if ($this->syncRowsWithHeading && $this->heading !== []) {
             // each key has an index
             $keyIndex = array_flip(array_keys($this->heading));
 
@@ -303,7 +303,7 @@ public function generate($tableData = null)
     {
         // The table data can optionally be passed to this function
         // either as a database result object or an array
-        if (! empty($tableData)) {
+        if ($tableData !== null && $tableData !== []) {
             if ($tableData instanceof BaseResult) {
                 $this->_setFromDBResult($tableData);
             } elseif (is_array($tableData)) {
@@ -312,7 +312,7 @@ public function generate($tableData = null)
         }
 
         // Is there anything to display? No? Smite them!
-        if (empty($this->heading) && $this->rows === []) {
+        if ($this->heading === [] && $this->rows === []) {
             return 'Undefined table data';
         }
 
@@ -333,7 +333,7 @@ public function generate($tableData = null)
         }
 
         // Is there a table heading to display?
-        if (! empty($this->heading)) {
+        if ($this->heading !== []) {
             $headerTag = null;
 
             if (preg_match('/(<)(td|th)(?=\h|>)/i', $this->template['heading_cell_start'], $matches) === 1) {
@@ -399,7 +399,7 @@ public function generate($tableData = null)
         }
 
         // Any table footing to display?
-        if (! empty($this->footing)) {
+        if ($this->footing !== []) {
             $footerTag = null;
 
             if (preg_match('/(<)(td|th)(?=\h|>)/i', $this->template['footing_cell_start'], $matches)) {
@@ -458,7 +458,7 @@ public function clear()
     protected function _setFromDBResult($object)
     {
         // First generate the headings from the table column names
-        if ($this->autoHeading && empty($this->heading)) {
+        if ($this->autoHeading && $this->heading === []) {
             $this->heading = $this->_prepArgs($object->getFieldNames());
         }
 
@@ -476,7 +476,7 @@ protected function _setFromDBResult($object)
      */
     protected function _setFromArray($data)
     {
-        if ($this->autoHeading && empty($this->heading)) {
+        if ($this->autoHeading && $this->heading === []) {
             $this->heading = $this->_prepArgs(array_shift($data));
         }
 

system/View/View.php

@@ -178,7 +178,7 @@ public function render(string $view, ?array $options = null, ?bool $saveData = n
 
         $fileExt = pathinfo($view, PATHINFO_EXTENSION);
         // allow Views as .html, .tpl, etc (from CI3)
-        $this->renderVars['view'] = empty($fileExt) ? $view . '.php' : $view;
+        $this->renderVars['view'] = ($fileExt === '') ? $view . '.php' : $view;
 
         $this->renderVars['options'] = $options ?? [];
 
@@ -207,12 +207,12 @@ public function render(string $view, ?array $options = null, ?bool $saveData = n
             $this->renderVars['file'] = $this->loader->locateFile(
                 $this->renderVars['view'],
                 'Views',
-                empty($fileExt) ? 'php' : $fileExt
+                ($fileExt === '') ? 'php' : $fileExt
             );
         }
 
-        // locateFile will return an empty string if the file cannot be found.
-        if (empty($this->renderVars['file'])) {
+        // locateFile() will return false if the file cannot be found.
+        if ($this->renderVars['file'] === false) {
             throw ViewException::forInvalidFile($this->renderVars['view']);
         }