Merge pull request #7790 from kai890707/20230807-file-phpstan

Fix: Remove the `File` ignore errors.

Author: kenjis

phpstan-baseline.php

@@ -906,26 +906,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Exceptions/TestException.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Files\\\\Exceptions\\\\FileException\\:\\:forExpectedDirectory\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Files/Exceptions/FileException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Files\\\\Exceptions\\\\FileException\\:\\:forExpectedFile\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Files/Exceptions/FileException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Files\\\\Exceptions\\\\FileException\\:\\:forUnableToMove\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Files/Exceptions/FileException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Files\\\\Exceptions\\\\FileNotFoundException\\:\\:forFileNotFound\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Files/Exceptions/FileNotFoundException.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Property CodeIgniter\\\\Files\\\\File\\:\\:\\$size \\(int\\) on left side of \\?\\? is not nullable\\.$#',
 	'count' => 1,

system/Files/Exceptions/FileException.php

@@ -19,6 +19,9 @@ class FileException extends RuntimeException implements ExceptionInterface
 {
     use DebugTraceableTrait;
 
+    /**
+     * @return static
+     */
     public static function forUnableToMove(?string $from = null, ?string $to = null, ?string $error = null)
     {
         return new static(lang('Files.cannotMove', [$from, $to, $error]));
@@ -28,6 +31,8 @@ public static function forUnableToMove(?string $from = null, ?string $to = null,
      * Throws when an item is expected to be a directory but is not or is missing.
      *
      * @param string $caller The method causing the exception
+     *
+     * @return static
      */
     public static function forExpectedDirectory(string $caller)
     {
@@ -38,6 +43,8 @@ public static function forExpectedDirectory(string $caller)
      * Throws when an item is expected to be a file but is not or is missing.
      *
      * @param string $caller The method causing the exception
+     *
+     * @return static
      */
     public static function forExpectedFile(string $caller)
     {

system/Files/Exceptions/FileNotFoundException.php

@@ -19,6 +19,9 @@ class FileNotFoundException extends RuntimeException implements ExceptionInterfa
 {
     use DebugTraceableTrait;
 
+    /**
+     * @return static
+     */
     public static function forFileNotFound(string $path)
     {
         return new static(lang('Files.fileNotFound', [$path]));