refactor ComposerJsonTest

Author: paulbalandan

tests/system/AutoReview/ComposerJsonTest.php

@@ -13,6 +13,7 @@
 
 namespace CodeIgniter\AutoReview;
 
+use InvalidArgumentException;
 use JsonException;
 use PHPUnit\Framework\TestCase;
 
@@ -40,7 +41,7 @@ protected function setUp(): void
 
     public function testFrameworkRequireIsTheSameWithDevRequire(): void
     {
-        $this->checkFramework('require');
+        $this->checkSection('require', 'framework');
     }
 
     public function testFrameworkRequireDevIsTheSameWithDevRequireDev(): void
@@ -68,7 +69,7 @@ public function testFrameworkRequireDevIsTheSameWithDevRequireDev(): void
 
     public function testFrameworkSuggestIsTheSameWithDevSuggest(): void
     {
-        $this->checkFramework('suggest');
+        $this->checkSection('suggest', 'framework');
     }
 
     public function testFrameworkConfigIsTheSameWithDevSuggest(): void
@@ -89,21 +90,25 @@ public function testStarterConfigIsTheSameWithDevSuggest(): void
         );
     }
 
-    private function checkFramework(string $section): void
+    private function checkSection(string $section, string $component): void
     {
-        $this->assertSame(
-            $this->devComposer[$section],
-            $this->frameworkComposer[$section],
-            'The framework\'s "' . $section . '" section is not updated with the main composer.json.'
-        );
-    }
+        switch (strtolower($component)) {
+            case 'framework':
+                $sectionContent = $this->frameworkComposer[$section] ?? null;
+                break;
+
+            case 'starter':
+                $sectionContent = $this->starterComposer[$section] ?? null;
+                break;
+
+            default:
+                throw new InvalidArgumentException(sprintf('Unknown component: %s.', $component));
+        }
 
-    private function checkStarter(string $section): void
-    {
         $this->assertSame(
             $this->devComposer[$section],
-            $this->starterComposer[$section],
-            'The starter\'s "' . $section . '" section is not updated with the main composer.json.'
+            $sectionContent,
+            sprintf('The %s\'s "%s" section is not updated with the main composer.json', strtolower($component), $section)
         );
     }