refactor: apply DisallowedEmptyRuleFixerRector

Author: kenjis

system/API/ResponseTrait.php

@@ -94,7 +94,7 @@ protected function respond($data = null, ?int $status = null, string $message =
             $output = null;
             $this->format($data);
         } else {
-            $status = empty($status) ? 200 : $status;
+            $status = $status === null || $status === 0 ? 200 : $status;
             $output = $this->format($data);
         }
 

system/Autoloader/FileLocator.php

@@ -51,7 +51,7 @@ public function locateFile(string $file, ?string $folder = null, string $ext = '
         $file = $this->ensureExt($file, $ext);
 
         // Clears the folder name if it is at the beginning of the filename
-        if (! empty($folder) && strpos($file, $folder) === 0) {
+        if ($folder !== null && $folder !== '' && $folder !== '0' && strpos($file, $folder) === 0) {
             $file = substr($file, strlen($folder . '/'));
         }
 
@@ -101,7 +101,7 @@ public function locateFile(string $file, ?string $folder = null, string $ext = '
             // If we have a folder name, then the calling function
             // expects this file to be within that folder, like 'Views',
             // or 'libraries'.
-            if (! empty($folder) && strpos($path . $filename, '/' . $folder . '/') === false) {
+            if ($folder !== null && $folder !== '' && $folder !== '0' && strpos($path . $filename, '/' . $folder . '/') === false) {
                 $path .= trim($folder, '/') . '/';
             }
 
@@ -154,7 +154,7 @@ public function getClassname(string $file): string
             }
         }
 
-        if (empty($className)) {
+        if ($className === '' || $className === '0') {
             return '';
         }
 
@@ -305,7 +305,7 @@ public function findQualifiedNameFromPath(string $path)
      */
     public function listFiles(string $path): array
     {
-        if (empty($path)) {
+        if ($path === '' || $path === '0') {
             return [];
         }
 
@@ -338,7 +338,7 @@ public function listFiles(string $path): array
      */
     public function listNamespaceFiles(string $prefix, string $path): array
     {
-        if (empty($path) || empty($prefix)) {
+        if ($path === '' || $path === '0' || ($prefix === '' || $prefix === '0')) {
             return [];
         }
 
@@ -372,7 +372,7 @@ public function listNamespaceFiles(string $prefix, string $path): array
      */
     protected function legacyLocate(string $file, ?string $folder = null)
     {
-        $path = APPPATH . (empty($folder) ? $file : $folder . '/' . $file);
+        $path = APPPATH . ($folder === null || $folder === '' || $folder === '0' ? $file : $folder . '/' . $file);
         $path = realpath($path) ?: $path;
 
         if (is_file($path)) {

system/BaseModel.php

@@ -1579,7 +1579,7 @@ public function getValidationMessages(): array
      */
     protected function cleanValidationRules(array $rules, ?array $row = null): array
     {
-        if (empty($row)) {
+        if ($row === null || $row === []) {
             return [];
         }
 
@@ -1795,7 +1795,7 @@ protected function transformDataToArray($row, string $type): array
         }
 
         // If it's still empty here, means $row is no change or is empty object
-        if (! $this->allowEmptyInserts && empty($row)) {
+        if (! $this->allowEmptyInserts && ($row === null || $row === [])) {
             throw DataException::forEmptyDataset($type);
         }
 

system/CLI/CLI.php

@@ -849,7 +849,7 @@ public static function showProgress($thisStep = 1, int $totalSteps = 10)
      */
     public static function wrap(?string $string = null, int $max = 0, int $padLeft = 0): string
     {
-        if (empty($string)) {
+        if ($string === null || $string === '' || $string === '0') {
             return '';
         }
 

system/Cache/CacheFactory.php

@@ -52,8 +52,8 @@ public static function getHandler(Cache $config, ?string $handler = null, ?strin
             throw CacheException::forNoBackup();
         }
 
-        $handler = ! empty($handler) ? $handler : $config->handler;
-        $backup  = ! empty($backup) ? $backup : $config->backupHandler;
+        $handler = $handler !== null && $handler !== '' && $handler !== '0' ? $handler : $config->handler;
+        $backup  = $backup !== null && $backup !== '' && $backup !== '0' ? $backup : $config->backupHandler;
 
         if (! array_key_exists($handler, $config->validHandlers) || ! array_key_exists($backup, $config->validHandlers)) {
             throw CacheException::forHandlerNotFound();

system/Common.php

@@ -291,7 +291,7 @@ function csrf_hash(): string
      */
     function csrf_field(?string $id = null): string
     {
-        return '<input type="hidden"' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_token() . '" value="' . csrf_hash() . '"' . _solidus() . '>';
+        return '<input type="hidden"' . ($id !== null && $id !== '' && $id !== '0' ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_token() . '" value="' . csrf_hash() . '"' . _solidus() . '>';
     }
 }
 
@@ -301,7 +301,7 @@ function csrf_field(?string $id = null): string
      */
     function csrf_meta(?string $id = null): string
     {
-        return '<meta' . (! empty($id) ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_header() . '" content="' . csrf_hash() . '"' . _solidus() . '>';
+        return '<meta' . ($id !== null && $id !== '' && $id !== '0' ? ' id="' . esc($id, 'attr') . '"' : '') . ' name="' . csrf_header() . '" content="' . csrf_hash() . '"' . _solidus() . '>';
     }
 }
 
@@ -856,7 +856,7 @@ function redirect(?string $route = null): RedirectResponse
     {
         $response = Services::redirectresponse(null, true);
 
-        if (! empty($route)) {
+        if ($route !== null && $route !== '' && $route !== '0') {
             return $response->route($route);
         }
 
@@ -1129,7 +1129,7 @@ function timer(?string $name = null, ?callable $callable = null)
     {
         $timer = Services::timer();
 
-        if (empty($name)) {
+        if ($name === null || $name === '' || $name === '0') {
             return $timer;
         }
 

system/Database/BaseBuilder.php

@@ -318,7 +318,7 @@ public function __construct($tableName, ConnectionInterface $db, ?array $options
 
         $this->from($tableName);
 
-        if (! empty($options)) {
+        if ($options !== null && $options !== []) {
             foreach ($options as $key => $value) {
                 if (property_exists($this, $key)) {
                     $this->{$key} = $value;
@@ -928,7 +928,7 @@ public function orHavingNotIn(?string $key = null, $values = null, ?bool $escape
      */
     protected function _whereIn(?string $key = null, $values = null, bool $not = false, string $type = 'AND ', ?bool $escape = null, string $clause = 'QBWhere')
     {
-        if (empty($key) || ! is_string($key)) {
+        if ($key === null || $key === '' || $key === '0' || ! is_string($key)) {
             throw new InvalidArgumentException(sprintf('%s() expects $key to be a non-empty string', debug_backtrace(0, 2)[1]['function']));
         }
 
@@ -1434,7 +1434,7 @@ public function orHaving($key, $value = null, ?bool $escape = null)
     public function orderBy(string $orderBy, string $direction = '', ?bool $escape = null)
     {
         $qbOrderBy = [];
-        if (empty($orderBy)) {
+        if ($orderBy === '' || $orderBy === '0') {
             return $this;
         }
 
@@ -1490,7 +1490,7 @@ public function limit(?int $value = null, ?int $offset = 0)
             $this->QBLimit = $value;
         }
 
-        if (! empty($offset)) {
+        if ($offset !== null && $offset !== 0) {
             $this->QBOffset = $offset;
         }
 
@@ -1504,7 +1504,7 @@ public function limit(?int $value = null, ?int $offset = 0)
      */
     public function offset(int $offset)
     {
-        if (! empty($offset)) {
+        if ($offset !== 0) {
             $this->QBOffset = (int) $offset;
         }
 
@@ -1736,7 +1736,7 @@ public function getWhere($where = null, ?int $limit = null, ?int $offset = 0, bo
             $this->where($where);
         }
 
-        if (! empty($limit)) {
+        if ($limit !== null && $limit !== 0) {
             $this->limit($limit, $offset);
         }
 
@@ -2452,7 +2452,7 @@ public function update($set = null, $where = null, ?int $limit = null): bool
             $this->where($where);
         }
 
-        if (! empty($limit)) {
+        if ($limit !== null && $limit !== 0) {
             if (! $this->canLimitWhereUpdates) {
                 throw new DatabaseException('This driver does not allow LIMITs on UPDATE queries using WHERE.');
             }
@@ -2762,7 +2762,7 @@ public function delete($where = '', ?int $limit = null, bool $resetData = true)
 
         $sql = $this->_delete($this->removeAlias($table));
 
-        if (! empty($limit)) {
+        if ($limit !== null && $limit !== 0) {
             $this->QBLimit = $limit;
         }
 
@@ -3172,7 +3172,7 @@ protected function compileGroupBy(): string
      */
     protected function compileOrderBy(): string
     {
-        if (is_array($this->QBOrderBy) && ! empty($this->QBOrderBy)) {
+        if (is_array($this->QBOrderBy) && $this->QBOrderBy !== []) {
             foreach ($this->QBOrderBy as &$orderBy) {
                 if ($orderBy['escape'] !== false && ! $this->isLiteral($orderBy['field'])) {
                     $orderBy['field'] = $this->db->protectIdentifiers($orderBy['field']);
@@ -3265,10 +3265,10 @@ protected function isLiteral(string $str): bool
     {
         $str = trim($str);
 
-        if (empty($str)
-            || ctype_digit($str)
-            || (string) (float) $str === $str
-            || in_array(strtoupper($str), ['TRUE', 'FALSE'], true)
+        if ($str === '' || $str === '0'
+                        || ctype_digit($str)
+                        || (string) (float) $str === $str
+                        || in_array(strtoupper($str), ['TRUE', 'FALSE'], true)
         ) {
             return true;
         }

system/Database/Database.php

@@ -104,7 +104,7 @@ protected function parseDSN(array $params): array
             'database' => isset($dsn['path']) ? rawurldecode(substr($dsn['path'], 1)) : '',
         ];
 
-        if (! empty($dsn['query'])) {
+        if (isset($dsn['query']) && ($dsn['query'] !== '' && $dsn['query'] !== '0')) {
             parse_str($dsn['query'], $extra);
 
             foreach ($extra as $key => $val) {

system/Database/MigrationRunner.php

@@ -639,7 +639,7 @@ public function getHistory(string $group = 'default'): array
         $builder = $this->db->table($this->table);
 
         // If group was specified then use it
-        if (! empty($group)) {
+        if ($group !== '' && $group !== '0') {
             $builder->where('group', $group);
         }
 

system/Database/MySQLi/Connection.php

@@ -150,7 +150,7 @@ public function connect(bool $persistent = false)
                 $ssl['cipher'] = $this->encrypt['ssl_cipher'];
             }
 
-            if (! empty($ssl)) {
+            if ($ssl !== []) {
                 if (isset($this->encrypt['ssl_verify'])) {
                     if ($this->encrypt['ssl_verify']) {
                         if (defined('MYSQLI_OPT_SSL_VERIFY_SERVER_CERT')) {