implement changes from code review

michalsn · michalsn · commit ca6c800d5cf9 · 2023-09-15T10:29:18.000+02:00
diff --git a/system/Security/Security.php b/system/Security/Security.php
@@ -354,7 +354,8 @@ private function getPostedToken(RequestInterface $request): ?string
         $body = (string) $request->getBody();
 
         if ($body !== '') {
-            if (! empty($json = json_decode($body)) && json_last_error() === JSON_ERROR_NONE) {
+            $json = json_decode($body);
+            if (! empty($json) && json_last_error() === JSON_ERROR_NONE) {
                 return $json->{$this->config->tokenName} ?? null;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,8 @@ private function getPostedToken(RequestInterface $request): ?string`
`354`	`354`	`$body = (string) $request->getBody();`
`355`	`355`
`356`	`356`	`if ($body !== '') {`
`357`		`- if (! empty($json = json_decode($body)) && json_last_error() === JSON_ERROR_NONE) {`
	`357`	`+ $json = json_decode($body);`
	`358`	`+ if (! empty($json) && json_last_error() === JSON_ERROR_NONE) {`
`358`	`359`	`return $json->{$this->config->tokenName} ?? null;`
`359`	`360`	`}`
`360`	`361`