Merge pull request #7086 from kenjis/fix-docs-upgrade_430-ErrorFilter

kenjis · web-flow · commit c58f45dc3ede · 2023-01-11T15:03:35.000+09:00
docs: improve upgrade_430.rst
diff --git a/user_guide_src/source/installation/upgrade_430.rst b/user_guide_src/source/installation/upgrade_430.rst
@@ -141,12 +141,13 @@ The way error and output streams are captured has changed. Now instead of::
     protected function setUp(): void
     {
         CITestStreamFilter::$buffer = '';
-        $this->stream_filter        = stream_filter_append(STDOUT, 'CITestStreamFilter');
+        $this->streamFilter         = stream_filter_append(STDOUT, 'CITestStreamFilter');
+        $this->streamFilter         = stream_filter_append(STDERR, 'CITestStreamFilter');
     }
 
     protected function tearDown(): void
     {
-        stream_filter_remove($this->stream_filter);
+        stream_filter_remove($this->streamFilter);
     }
 
 need to use::
@@ -157,11 +158,13 @@ need to use::
     {
         CITestStreamFilter::registration();
         CITestStreamFilter::addOutputFilter();
+        CITestStreamFilter::addErrorFilter();
     }
 
     protected function tearDown(): void
     {
         CITestStreamFilter::removeOutputFilter();
+        CITestStreamFilter::removeErrorFilter();
     }
 
 Or use the trait ``CodeIgniter\Test\StreamFilterTrait``. See :ref:`testing-cli-output`.

Original file line number	Diff line number	Diff line change
`@@ -141,12 +141,13 @@ The way error and output streams are captured has changed. Now instead of::`
`141`	`141`	`protected function setUp(): void`
`142`	`142`	`{`
`143`	`143`	`CITestStreamFilter::$buffer = '';`
`144`		`- $this->stream_filter = stream_filter_append(STDOUT, 'CITestStreamFilter');`
	`144`	`+ $this->streamFilter = stream_filter_append(STDOUT, 'CITestStreamFilter');`
	`145`	`+ $this->streamFilter = stream_filter_append(STDERR, 'CITestStreamFilter');`
`145`	`146`	`}`
`146`	`147`
`147`	`148`	`protected function tearDown(): void`
`148`	`149`	`{`
`149`		`- stream_filter_remove($this->stream_filter);`
	`150`	`+ stream_filter_remove($this->streamFilter);`
`150`	`151`	`}`
`151`	`152`
`152`	`153`	`need to use::`
`@@ -157,11 +158,13 @@ need to use::`
`157`	`158`	`{`
`158`	`159`	`CITestStreamFilter::registration();`
`159`	`160`	`CITestStreamFilter::addOutputFilter();`
	`161`	`+ CITestStreamFilter::addErrorFilter();`
`160`	`162`	`}`
`161`	`163`
`162`	`164`	`protected function tearDown(): void`
`163`	`165`	`{`
`164`	`166`	`CITestStreamFilter::removeOutputFilter();`
	`167`	`+ CITestStreamFilter::removeErrorFilter();`
`165`	`168`	`}`
`166`	`169`
`167`	`170`	Or use the trait ``CodeIgniter\Test\StreamFilterTrait``. See :ref:`testing-cli-output`.