Skip to content

Commit bab8f77

Browse files
committed
docs: add comments
1 parent 0a8164b commit bab8f77

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

system/HTTP/IncomingRequest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,9 @@ public function isSecure(): bool
451451
public function setPath(string $path, ?App $config = null)
452452
{
453453
$this->path = $path;
454+
455+
// @TODO remove this. The path of the URI object should be a full URI path,
456+
// not a URI path relative to baseURL.
454457
$this->uri->setPath($path);
455458

456459
$config ??= $this->config;
@@ -481,6 +484,9 @@ public function setPath(string $path, ?App $config = null)
481484
$this->uri->setScheme('https');
482485
}
483486
} elseif (! is_cli()) {
487+
// Do not change exit() to exception; Request is initialized before
488+
// setting the exception handler, so if an exception is raised, an
489+
// error will be displayed in the production environment.
484490
// @codeCoverageIgnoreStart
485491
exit('You have an empty or invalid base URL. The baseURL value must be set in Config\App.php, or through the .env file.');
486492
// @codeCoverageIgnoreEnd

0 commit comments

Comments
 (0)