Merge pull request #6942 from codeigniter4/dependabot/composer/rector/rector-0.15.0

chore(deps-dev): update rector/rector requirement from 0.14.8 to 0.15.0

Author: samsonasik

composer.json

@@ -25,7 +25,7 @@
         "phpunit/phpcov": "^8.2",
         "phpunit/phpunit": "^9.1",
         "predis/predis": "^1.1 || ^2.0",
-        "rector/rector": "0.14.8"
+        "rector/rector": "0.15.0"
     },
     "suggest": {
         "ext-curl": "If you use CURLRequest class",

rector.php

@@ -46,6 +46,7 @@
 use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
 use Utils\Rector\PassStrictParameterToFunctionParameterRector;
 use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
 use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -119,6 +120,9 @@
         GetMockBuilderGetMockToCreateMockRector::class => [
             __DIR__ . '/tests/system/Email/EmailTest.php',
         ],
+
+        // buggy on union mixed type, new class extends SomeClass marked as object in union, and false replaced with bool in Union
+        TypedPropertyFromAssignsRector::class,
     ]);
 
     // auto import fully qualified class names

tests/system/API/ResponseTraitTest.php

@@ -29,8 +29,16 @@
  */
 final class ResponseTraitTest extends CIUnitTestCase
 {
+    /**
+     * @var MockIncomingRequest|null
+     */
     private $request;
+
+    /**
+     * @var MockResponse|null
+     */
     private $response;
+
     private ?FormatterInterface $formatter = null;
 
     protected function setUp(): void

tests/system/CLI/CLITest.php

@@ -23,6 +23,9 @@
  */
 final class CLITest extends CIUnitTestCase
 {
+    /**
+     * @var false|resource
+     */
     private $stream_filter;
 
     protected function setUp(): void

tests/system/CLI/CommandRunnerTest.php

@@ -24,7 +24,7 @@
 final class CommandRunnerTest extends CIUnitTestCase
 {
     /**
-     * @var resource
+     * @var false|resource
      */
     private $streamFilter;
 

tests/system/CLI/ConsoleTest.php

@@ -27,6 +27,10 @@
 final class ConsoleTest extends CIUnitTestCase
 {
     private DotEnv $env;
+
+    /**
+     * @var false|resource
+     */
     private $stream_filter;
 
     protected function setUp(): void

tests/system/Commands/BaseCommandTest.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Commands;
 
+use CodeIgniter\Log\Logger;
 use CodeIgniter\Test\CIUnitTestCase;
 use Config\Services;
 use Tests\Support\Commands\AppInfo;
@@ -22,7 +23,7 @@
  */
 final class BaseCommandTest extends CIUnitTestCase
 {
-    private $logger;
+    private Logger $logger;
 
     protected function setUp(): void
     {

tests/system/Commands/ClearCacheTest.php

@@ -23,6 +23,9 @@
  */
 final class ClearCacheTest extends CIUnitTestCase
 {
+    /**
+     * @var false|resource
+     */
     private $streamFilter;
 
     protected function setUp(): void

tests/system/Commands/ClearDebugbarTest.php

@@ -21,8 +21,12 @@
  */
 final class ClearDebugbarTest extends CIUnitTestCase
 {
+    /**
+     * @var false|resource
+     */
     private $streamFilter;
-    private $time;
+
+    private int $time;
 
     protected function setUp(): void
     {

tests/system/Commands/ClearLogsTest.php

@@ -21,8 +21,12 @@
  */
 final class ClearLogsTest extends CIUnitTestCase
 {
+    /**
+     * @var false|resource
+     */
     private $streamFilter;
-    private $date;
+
+    private string $date;
 
     protected function setUp(): void
     {