refactor: replace empty()

kenjis · kenjis · commit 9c5275ebf086 · 2022-10-23T13:03:04.000+09:00
diff --git a/system/Database/Config.php b/system/Database/Config.php
@@ -59,7 +59,7 @@ public static function connect($group = null, bool $getShared = true)
         /** @var DbConfig $dbConfig */
         $dbConfig = config('Database');
 
-        if (empty($group)) {
+        if ($group === null) {
             $group = ENVIRONMENT === 'testing' ? 'tests' : $dbConfig->defaultGroup;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public static function connect($group = null, bool $getShared = true)`
`59`	`59`	`/** @var DbConfig $dbConfig */`
`60`	`60`	`$dbConfig = config('Database');`
`61`	`61`
`62`		`- if (empty($group)) {`
	`62`	`+ if ($group === null) {`
`63`	`63`	`$group = ENVIRONMENT === 'testing' ? 'tests' : $dbConfig->defaultGroup;`
`64`	`64`	`}`
`65`	`65`