fix: $fraction type

NumberFormatter::setAttribute(): Passing null to parameter #2 ($value) of type int|float is deprecated

Author: kenjis

system/Helpers/number_helper.php

@@ -116,7 +116,7 @@ function number_to_amount($num, int $precision = 0, ?string $locale = null)
      * @param string $locale
      * @param int    $fraction
      */
-    function number_to_currency(float $num, string $currency, ?string $locale = null, ?int $fraction = null): string
+    function number_to_currency(float $num, string $currency, ?string $locale = null, int $fraction = 0): string
     {
         return format_number($num, 1, $locale, [
             'type'     => NumberFormatter::CURRENCY,

tests/system/Helpers/NumberHelperTest.php

@@ -126,6 +126,7 @@ public function testQuadrillions()
      */
     public function testCurrencyCurrentLocale()
     {
+        $this->assertSame('$1,235', number_to_currency(1234.56, 'USD', 'en_US'));
         $this->assertSame('$1,234.56', number_to_currency(1234.56, 'USD', 'en_US', 2));
         $this->assertSame('£1,234.56', number_to_currency(1234.56, 'GBP', 'en_GB', 2));
         $this->assertSame("1.234,56\u{a0}RSD", number_to_currency(1234.56, 'RSD', 'sr_RS', 2));