Fix: The subquery adds a prefix for the table alias.

Author: iRedds

system/Database/BaseBuilder.php

@@ -2952,7 +2952,7 @@ protected function buildSubquery($builder, bool $wrapped = false, string $alias
             throw new DatabaseException('The subquery cannot be the same object as the main query object.');
         }
 
-        $subquery = strtr($builder->getCompiledSelect(), "\n", ' ');
+        $subquery = strtr($builder->getCompiledSelect(false), "\n", ' ');
 
         if ($wrapped) {
             $subquery = '(' . $subquery . ')';

tests/system/Database/Builder/PrefixTest.php

@@ -49,4 +49,24 @@ public function testPrefixesSetOnTableNamesWithWhereClause()
         $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledSelect()));
         $this->assertSame($expectedBinds, $builder->getBinds());
     }
+
+    public function testPrefixWithSubquery()
+    {
+        $expected = <<<'NOWDOC'
+            SELECT "u"."id", "u"."name", (SELECT 1 FROM "ci_users" "sub" WHERE "sub"."id" = "u"."id") "one"
+            FROM "ci_users" "u"
+            WHERE "u"."id" = 1
+            NOWDOC;
+
+        $subquery = $this->db->table('users sub')
+            ->select('1', false)
+            ->where('sub.id = u.id');
+
+        $builder = $this->db->table('users u')
+            ->select('u.id, u.name')
+            ->selectSubquery($subquery, 'one')
+            ->where('u.id', 1);
+
+        $this->assertSame($expected, $builder->getCompiledSelect());
+    }
 }

user_guide_src/source/changelogs/v4.2.5.rst

@@ -32,5 +32,6 @@ none.
 
 Bugs Fixed
 **********
+- When using subqueries in the main query, prefixes are added to the table alias.
 
 See the repo's `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_ for a complete list of bugs fixed.