Dev: Add the return type of image exception.

Author: ping-yee

phpstan-baseline.php

@@ -1366,56 +1366,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/I18n/TimeLegacy.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forEXIFUnsupported\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forFileNotSupported\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forImageProcessFailed\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forInvalidDirection\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forInvalidImageCreate\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forInvalidImageLibraryPath\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forInvalidPath\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forMissingAngle\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forMissingImage\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Images\\\\Exceptions\\\\ImageException\\:\\:forSaveFailed\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Images/Exceptions/ImageException.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Property CodeIgniter\\\\Images\\\\Handlers\\\\BaseHandler\\:\\:\\$image \\(CodeIgniter\\\\Images\\\\Image\\) in empty\\(\\) is not falsy\\.$#',
 	'count' => 1,

system/Images/Exceptions/ImageException.php

@@ -16,52 +16,52 @@
 
 class ImageException extends FrameworkException implements ExceptionInterface
 {
-    public static function forMissingImage()
+    public static function forMissingImage(): ImageException
     {
         return new static(lang('Images.sourceImageRequired'));
     }
 
-    public static function forFileNotSupported()
+    public static function forFileNotSupported(): ImageException
     {
         return new static(lang('Images.fileNotSupported'));
     }
 
-    public static function forMissingAngle()
+    public static function forMissingAngle(): ImageException
     {
         return new static(lang('Images.rotationAngleRequired'));
     }
 
-    public static function forInvalidDirection(?string $dir = null)
+    public static function forInvalidDirection(?string $dir = null): ImageException
     {
         return new static(lang('Images.invalidDirection', [$dir]));
     }
 
-    public static function forInvalidPath()
+    public static function forInvalidPath(): ImageException
     {
         return new static(lang('Images.invalidPath'));
     }
 
-    public static function forEXIFUnsupported()
+    public static function forEXIFUnsupported(): ImageException
     {
         return new static(lang('Images.exifNotSupported'));
     }
 
-    public static function forInvalidImageCreate(?string $extra = null)
+    public static function forInvalidImageCreate(?string $extra = null): ImageException
     {
         return new static(lang('Images.unsupportedImageCreate') . ' ' . $extra);
     }
 
-    public static function forSaveFailed()
+    public static function forSaveFailed(): ImageException
     {
         return new static(lang('Images.saveFailed'));
     }
 
-    public static function forInvalidImageLibraryPath(?string $path = null)
+    public static function forInvalidImageLibraryPath(?string $path = null): ImageException
     {
         return new static(lang('Images.libPathInvalid', [$path]));
     }
 
-    public static function forImageProcessFailed()
+    public static function forImageProcessFailed(): ImageException
     {
         return new static(lang('Images.imageProcessFailed'));
     }