refactor: fix non-boolean if condition

kenjis · kenjis · commit 872beb905649 · 2023-12-07T09:12:56.000+09:00
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -1161,7 +1161,7 @@ public function onlyDeleted()
     public function replace(?array $data = null, bool $returnSQL = false)
     {
         // Validate data before saving.
-        if ($data && ! $this->skipValidation && ! $this->validate($data)) {
+        if (($data !== null) && ! $this->skipValidation && ! $this->validate($data)) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1161,7 +1161,7 @@ public function onlyDeleted()`
`1161`	`1161`	`public function replace(?array $data = null, bool $returnSQL = false)`
`1162`	`1162`	`{`
`1163`	`1163`	`// Validate data before saving.`
`1164`		`- if ($data && ! $this->skipValidation && ! $this->validate($data)) {`
	`1164`	`+ if (($data !== null) && ! $this->skipValidation && ! $this->validate($data)) {`
`1165`	`1165`	`return false;`
`1166`	`1166`	`}`
`1167`	`1167`