refactor: replace empty()

Author: kenjis

system/Test/Fabricator.php

@@ -128,7 +128,7 @@ public function __construct($model, ?array $formatters = null, ?string $locale =
 
         // Determine eligible date fields
         foreach (['createdField', 'updatedField', 'deletedField'] as $field) {
-            if (! empty($this->model->{$field})) {
+            if (isset($this->model->{$field})) {
                 $this->dateFields[] = $this->model->{$field};
             }
         }
@@ -152,7 +152,7 @@ public static function resetCounts()
      */
     public static function getCount(string $table): int
     {
-        return empty(self::$tableCounts[$table]) ? 0 : self::$tableCounts[$table];
+        return ! isset(self::$tableCounts[$table]) ? 0 : self::$tableCounts[$table];
     }
 
     /**
@@ -282,7 +282,7 @@ protected function detectFormatters(): self
     {
         $this->formatters = [];
 
-        if (! empty($this->model->allowedFields)) {
+        if (isset($this->model->allowedFields)) {
             foreach ($this->model->allowedFields as $field) {
                 $this->formatters[$field] = $this->guessFormatter($field);
             }
@@ -513,12 +513,12 @@ protected function createMock(?int $count = null)
         // Determine which fields we will need
         $fields = [];
 
-        if (! empty($this->model->useTimestamps)) {
+        if ($this->model->useTimestamps) {
             $fields[$this->model->createdField] = $datetime;
             $fields[$this->model->updatedField] = $datetime;
         }
 
-        if (! empty($this->model->useSoftDeletes)) {
+        if ($this->model->useSoftDeletes) {
             $fields[$this->model->deletedField] = null;
         }
 

system/Test/FeatureTestCase.php

@@ -186,7 +186,7 @@ public function call(string $method, string $path, ?array $params = null)
             ->run($routes, true);
 
         $output = \ob_get_contents();
-        if (empty($response->getBody()) && ! ($output === '' || $output === false)) {
+        if (($response->getBody() === null) && ! ($output === '' || $output === false)) {
             $response->setBody($output);
         }
 

system/Test/Mock/MockCache.php

@@ -22,7 +22,7 @@ class MockCache extends BaseHandler implements CacheInterface
     /**
      * Mock cache storage.
      *
-     * @var array
+     * @var array<string, mixed>
      */
     protected $cache = [];
 
@@ -155,7 +155,7 @@ public function increment(string $key, int $offset = 1)
         $key  = static::validateKey($key, $this->prefix);
         $data = $this->cache[$key] ?: null;
 
-        if (empty($data)) {
+        if ($data === null) {
             $data = 0;
         } elseif (! is_int($data)) {
             return false;
@@ -175,7 +175,7 @@ public function decrement(string $key, int $offset = 1)
 
         $data = $this->cache[$key] ?: null;
 
-        if (empty($data)) {
+        if ($data === null) {
             $data = 0;
         } elseif (! is_int($data)) {
             return false;
@@ -281,9 +281,9 @@ public function assertHasValue(string $key, $value = null)
     {
         $item = $this->get($key);
 
-        // Let assertHas handle throwing the error for consistency
+        // Let assertHas() handle throwing the error for consistency
         // if the key is not found
-        if (empty($item)) {
+        if ($item === null) {
             $this->assertHas($key);
         }
 

system/Test/Mock/MockConnection.php

@@ -62,7 +62,7 @@ public function query(string $sql, $binds = null, bool $setEscapeFlags = true, s
 
         $query->setQuery($sql, $binds, $setEscapeFlags);
 
-        if (! empty($this->swapPre) && ! empty($this->DBPrefix)) {
+        if ($this->swapPre !== '' && $this->DBPrefix !== '') {
             $query->swapPrefix($this->DBPrefix, $this->swapPre);
         }