refactore: remove @ that does not make sense, and cast to string

kenjis · kenjis · commit 78b0ac6ef9d1 · 2023-07-24T09:32:33.000+09:00
Because it might be false.
diff --git a/system/HTTP/SiteURIFactory.php b/system/HTTP/SiteURIFactory.php
@@ -178,7 +178,7 @@ private function parseRequestURI(): string
      */
     private function parseQueryString(): string
     {
-        $query = $this->superglobals->server('QUERY_STRING') ?? @getenv('QUERY_STRING');
+        $query = $this->superglobals->server('QUERY_STRING') ?? (string) getenv('QUERY_STRING');
 
         if (trim($query, '/') === '') {
             return '/';

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ private function parseRequestURI(): string`
`178`	`178`	`*/`
`179`	`179`	`private function parseQueryString(): string`
`180`	`180`	`{`
`181`		`- $query = $this->superglobals->server('QUERY_STRING') ?? @getenv('QUERY_STRING');`
	`181`	`+ $query = $this->superglobals->server('QUERY_STRING') ?? (string) getenv('QUERY_STRING');`
`182`	`182`
`183`	`183`	`if (trim($query, '/') === '') {`
`184`	`184`	`return '/';`