fix: SQLite3 getFieldData() returns incorrect primary_key values

The return type is integer, not boolean.

Author: kenjis

system/Database/SQLite3/Connection.php

@@ -273,7 +273,7 @@ protected function _fieldData(string $table): array
             $retVal[$i]->type        = $query[$i]->type;
             $retVal[$i]->max_length  = null;
             $retVal[$i]->default     = $query[$i]->dflt_value;
-            $retVal[$i]->primary_key = isset($query[$i]->pk) && (bool) $query[$i]->pk;
+            $retVal[$i]->primary_key = $query[$i]->pk ?? false;
             $retVal[$i]->nullable    = isset($query[$i]->notnull) && ! (bool) $query[$i]->notnull;
         }
 

tests/system/Database/Live/ForgeTest.php

@@ -986,31 +986,31 @@ public function testAddFields(): void
                     'type'        => 'INTEGER',
                     'max_length'  => null,
                     'default'     => null,
-                    'primary_key' => true,
+                    'primary_key' => 1,
                     'nullable'    => true,
                 ],
                 1 => [
                     'name'        => 'username',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => null,
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
                 2 => [
                     'name'        => 'name',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => null,
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => true,
                 ],
                 3 => [
                     'name'        => 'active',
                     'type'        => 'INTEGER',
                     'max_length'  => null,
                     'default'     => '0',
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
             ];

tests/system/Database/Live/SQLite3/GetFieldDataTest.php

@@ -47,55 +47,55 @@ public function testGetFieldData(): void
                     'type'        => 'INTEGER',
                     'max_length'  => null,
                     'default'     => null, // The default value is not defined.
-                    'primary_key' => true,
+                    'primary_key' => 1,
                     'nullable'    => true,
                 ],
                 (object) [
                     'name'        => 'text_not_null',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => null, // The default value is not defined.
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
                 (object) [
                     'name'        => 'text_null',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => null, // The default value is not defined.
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => true,
                 ],
                 (object) [
                     'name'        => 'int_default_0',
                     'type'        => 'INT',
                     'max_length'  => null,
                     'default'     => '0', // int 0
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
                 (object) [
                     'name'        => 'text_default_null',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => 'NULL', // NULL value
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => true,
                 ],
                 (object) [
                     'name'        => 'text_default_text_null',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => "'null'", // string "null"
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
                 (object) [
                     'name'        => 'text_default_abc',
                     'type'        => 'VARCHAR',
                     'max_length'  => null,
                     'default'     => "'abc'", // string "abc"
-                    'primary_key' => false,
+                    'primary_key' => 0,
                     'nullable'    => false,
                 ],
             ]),