fix: random_string('crypto') may return string less than $len or ErrorException

Author: kenjis

system/Helpers/text_helper.php

@@ -573,6 +573,12 @@ function random_string(string $type = 'alnum', int $len = 8): string
                 return sha1(uniqid((string) mt_rand(), true));
 
             case 'crypto':
+                if ($len % 2 !== 0) {
+                    throw new InvalidArgumentException(
+                        'You must set an even number to the second parameter when you use `crypto`.'
+                    );
+                }
+
                 return bin2hex(random_bytes($len / 2));
         }
         // 'basic' type treated as default

tests/system/Helpers/TextHelperTest.php

@@ -12,6 +12,7 @@
 namespace CodeIgniter\Helpers;
 
 use CodeIgniter\Test\CIUnitTestCase;
+use InvalidArgumentException;
 
 /**
  * @internal
@@ -113,6 +114,19 @@ public function testRandomString()
         $this->assertSame(40, strlen($random = random_string('sha1')));
     }
 
+    /**
+     * @see https://github.com/codeigniter4/CodeIgniter4/issues/6330
+     */
+    public function testRandomStringCryptoOddNumber()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage(
+            'You must set an even number to the second parameter when you use `crypto`'
+        );
+
+        random_string('crypto', 9);
+    }
+
     public function testIncrementString()
     {
         $this->assertSame('my-test_1', increment_string('my-test'));