fix: HTTP method names should be uppercase

Author: kenjis

system/HTTP/IncomingRequest.php

@@ -383,19 +383,19 @@ public function negotiate(string $type, array $supported, bool $strictMatch = fa
      */
     public function is(string $value): bool
     {
-        $value = strtolower($value);
+        $valueUpper = strtoupper($value);
 
-        $httpMethods = ['get', 'post', 'put', 'delete', 'head', 'patch', 'options'];
+        $httpMethods = ['GET', 'POST', 'PUT', 'DELETE', 'HEAD', 'PATCH', 'OPTIONS'];
 
-        if (in_array($value, $httpMethods, true)) {
-            return strtolower($this->getMethod()) === $value;
+        if (in_array($valueUpper, $httpMethods, true)) {
+            return strtoupper($this->getMethod()) === $valueUpper;
         }
 
-        if ($value === 'json') {
+        if ($valueUpper === 'JSON') {
             return strpos($this->getHeaderLine('Content-Type'), 'application/json') !== false;
         }
 
-        if ($value === 'ajax') {
+        if ($valueUpper === 'AJAX') {
             return $this->isAJAX();
         }
 

tests/system/HTTP/IncomingRequestTest.php

@@ -624,19 +624,19 @@ public function testIsHTTPMethodLowerCase(string $value)
     {
         $request = $this->request->withMethod($value);
 
-        $this->assertTrue($request->is($value));
+        $this->assertTrue($request->is(strtolower($value)));
     }
 
     public function provideIsHTTPMethods(): Generator
     {
         yield from [
-            ['get'],
-            ['post'],
-            ['put'],
-            ['delete'],
-            ['head'],
-            ['patch'],
-            ['options'],
+            ['GET'],
+            ['POST'],
+            ['PUT'],
+            ['DELETE'],
+            ['HEAD'],
+            ['PATCH'],
+            ['OPTIONS'],
         ];
     }
 
@@ -645,7 +645,7 @@ public function provideIsHTTPMethods(): Generator
      */
     public function testIsHTTPMethodUpperCase(string $value)
     {
-        $request = $this->request->withMethod(strtoupper($value));
+        $request = $this->request->withMethod($value);
 
         $this->assertTrue($request->is($value));
     }