always clear response headers between requests

Author: michalsn

system/HTTP/CURLRequest.php

@@ -469,10 +469,8 @@ protected function applyBody(array $curlOptions = []): array
      */
     protected function setResponseHeaders(array $headers = [])
     {
-        if ($this->shareOptions === false) {
-            foreach ($this->response->headers() as $header) {
-                $this->response->removeHeader($header->getName());
-            }
+        foreach ($this->response->headers() as $header) {
+            $this->response->removeHeader($header->getName());
         }
 
         foreach ($headers as $header) {

tests/system/HTTP/CURLRequestTest.php

@@ -749,15 +749,15 @@ public function testSendContinuedWithManyHeaders()
         $this->assertSame('<title>Update success! config</title>', $response->getBody());
 
         $responseHeaderKeys = [
-            'Cache-Control',
-            'Content-Type',
             'Server',
             'Connection',
             'Keep-Alive',
             'Set-Cookie',
             'Date',
             'Expires',
+            'Cache-Control',
             'Pragma',
+            'Content-Type',
             'Transfer-Encoding',
         ];
         $this->assertSame($responseHeaderKeys, array_keys($response->headers()));
@@ -780,19 +780,19 @@ public function testResponseHeadersWithMultipleRequests()
 Cache-Control: no-store, no-cache, must-revalidate
 Pragma: no-cache
 Content-Type: application/xml; charset=utf-8
-Transfer-Encoding: chunked\x0d\x0a\x0d\x0a<title>Hello</title>";
+Transfer-Encoding: chunked\x0d\x0a\x0d\x0a<title>Hello1</title>";
         $request->setOutput($output);
 
-        $response = $request->get('answer');
+        $response = $request->get('answer1');
 
-        $this->assertSame('<title>Hello</title>', $response->getBody());
+        $this->assertSame('<title>Hello1</title>', $response->getBody());
 
         $responseHeaderKeys = [
-            'Cache-Control',
-            'Content-Type',
             'Server',
             'Expires',
+            'Cache-Control',
             'Pragma',
+            'Content-Type',
             'Transfer-Encoding',
         ];
         $this->assertSame($responseHeaderKeys, array_keys($response->headers()));
@@ -803,19 +803,17 @@ public function testResponseHeadersWithMultipleRequests()
 Server: ddos-guard
 Expires: Thu, 19 Nov 1982 08:52:00 GMT
 Content-Type: application/xml; charset=utf-8
-Transfer-Encoding: chunked\x0d\x0a\x0d\x0a<title>Hello</title>";
+Transfer-Encoding: chunked\x0d\x0a\x0d\x0a<title>Hello2</title>";
         $request->setOutput($output);
 
-        $response = $request->get('answer');
+        $response = $request->get('answer2');
 
-        $this->assertSame('<title>Hello</title>', $response->getBody());
+        $this->assertSame('<title>Hello2</title>', $response->getBody());
 
         $responseHeaderKeys = [
-            'Cache-Control',
-            'Content-Type',
             'Server',
             'Expires',
-            'Pragma',
+            'Content-Type',
             'Transfer-Encoding',
         ];
         $this->assertSame($responseHeaderKeys, array_keys($response->headers()));

user_guide_src/source/changelogs/v4.3.4.rst

@@ -27,7 +27,7 @@ Deprecations
 Bugs Fixed
 **********
 
-- **CURLRequest:** Clear response headers between requests when ``Config\CURLRequest::$shareOptions`` is disabled.
+- **CURLRequest:** Clear response headers between requests.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_