Skip to content

Commit 52b7f05

Browse files
committed
fix: remove abstract from methods
To avoid breaking existing custom driver classes.
1 parent 82bfd12 commit 52b7f05

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

system/Database/BaseConnection.php

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1666,22 +1666,34 @@ abstract protected function _foreignKeyData(string $table): array;
16661666
*
16671667
* If this feature is not supported, return empty string.
16681668
*
1669+
* @TODO This method should be abstract, but due to historical reasons,
1670+
* it provides the default implementation.
1671+
*
16691672
* @return string
16701673
*
16711674
* @see disableForeignKeyChecks()
16721675
*/
1673-
abstract protected function _disableForeignKeyChecks();
1676+
protected function _disableForeignKeyChecks()
1677+
{
1678+
return '';
1679+
}
16741680

16751681
/**
16761682
* Platform-specific SQL statement to enable foreign key checks.
16771683
*
16781684
* If this feature is not supported, return empty string.
16791685
*
1686+
* @TODO This method should be abstract, but due to historical reasons,
1687+
* it provides the default implementation.
1688+
*
16801689
* @return string
16811690
*
16821691
* @see enableForeignKeyChecks()
16831692
*/
1684-
abstract protected function _enableForeignKeyChecks();
1693+
protected function _enableForeignKeyChecks()
1694+
{
1695+
return '';
1696+
}
16851697

16861698
/**
16871699
* Accessor for properties if they exist.

0 commit comments

Comments
 (0)