Update BaseBuilder.php

objecttothis · web-flow · commit 45b9d1db7219 · 2023-12-07T12:20:19.000+04:00
The function returns false on failure, but on success it returns the BaseResult unless the pretend flag is set in the query() function. In that case it returns a Query object. Not having this in the PHPdoc is giving PHPStorm fits.
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -2270,7 +2270,7 @@ public function getCompiledInsert(bool $reset = true)
      *
      * @param array|object|null $set
      *
-     * @return bool
+     * @return bool|BaseResult|Query
      *
      * @throws DatabaseException
      */

Original file line number	Diff line number	Diff line change
`@@ -2270,7 +2270,7 @@ public function getCompiledInsert(bool $reset = true)`
`2270`	`2270`	`*`
`2271`	`2271`	`* @param array\|object\|null $set`
`2272`	`2272`	`*`
`2273`		`- * @return bool`
	`2273`	`+ * @return bool\|BaseResult\|Query`
`2274`	`2274`	`*`
`2275`	`2275`	`* @throws DatabaseException`
`2276`	`2276`	`*/`