Merge pull request #7088 from samsonasik/rector-enable-add-default

[Rector] Enable AddDefaultValueForUndefinedVariableRector

Author: samsonasik

phpstan-baseline.neon.dist

@@ -195,11 +195,6 @@ parameters:
 			count: 1
 			path: system/Helpers/number_helper.php
 
-		-
-			message: "#^Variable \\$count might not be defined\\.$#"
-			count: 1
-			path: system/Helpers/url_helper.php
-
 		-
 			message: "#^Property CodeIgniter\\\\Images\\\\Handlers\\\\BaseHandler\\:\\:\\$image \\(CodeIgniter\\\\Images\\\\Image\\) in empty\\(\\) is not falsy\\.$#"
 			count: 1
@@ -225,21 +220,6 @@ parameters:
 			count: 4
 			path: system/Images/Handlers/ImageMagickHandler.php
 
-		-
-			message: "#^Variable \\$gravity might not be defined\\.$#"
-			count: 1
-			path: system/Images/Handlers/ImageMagickHandler.php
-
-		-
-			message: "#^Variable \\$xAxis might not be defined\\.$#"
-			count: 1
-			path: system/Images/Handlers/ImageMagickHandler.php
-
-		-
-			message: "#^Variable \\$yAxis might not be defined\\.$#"
-			count: 1
-			path: system/Images/Handlers/ImageMagickHandler.php
-
 		-
 			message: "#^Call to an undefined method CodeIgniter\\\\Router\\\\RouteCollectionInterface\\:\\:getDefaultNamespace\\(\\)\\.$#"
 			count: 3

rector.php

@@ -36,7 +36,6 @@
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
-use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
 use Rector\Php70\Rector\FuncCall\RandomFunctionRector;
 use Rector\Php71\Rector\FuncCall\CountOnNullRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
@@ -106,9 +105,6 @@
         // sometime too detail
         CountOnNullRector::class,
 
-        // may not be unitialized on purpose
-        AddDefaultValueForUndefinedVariableRector::class,
-
         // use mt_rand instead of random_int on purpose on non-cryptographically random
         RandomFunctionRector::class,
 

system/Cache/Handlers/MemcachedHandler.php

@@ -124,7 +124,8 @@ public function initialize()
      */
     public function get(string $key)
     {
-        $key = static::validateKey($key, $this->prefix);
+        $data = [];
+        $key  = static::validateKey($key, $this->prefix);
 
         if ($this->memcached instanceof Memcached) {
             $data = $this->memcached->get($key);

system/Commands/Generators/MigrationGenerator.php

@@ -97,6 +97,7 @@ public function run(array $params)
      */
     protected function prepare(string $class): string
     {
+        $data            = [];
         $data['session'] = false;
 
         if ($this->getOption('session')) {

system/Commands/Generators/SessionMigrationGenerator.php

@@ -89,6 +89,7 @@ public function run(array $params)
      */
     protected function prepare(string $class): string
     {
+        $data            = [];
         $data['session'] = true;
         $data['table']   = $this->getOption('t');
         $data['DBGroup'] = $this->getOption('g');

system/Commands/Utilities/FilterCheck.php

@@ -72,6 +72,7 @@ class FilterCheck extends BaseCommand
      */
     public function run(array $params)
     {
+        $tbody = [];
         if (! isset($params[0], $params[1])) {
             CLI::error('You must specify a HTTP verb and a route.');
             CLI::write('  Usage: ' . $this->usage);

system/Database/BaseBuilder.php

@@ -1423,6 +1423,7 @@ public function orHaving($key, $value = null, ?bool $escape = null)
      */
     public function orderBy(string $orderBy, string $direction = '', ?bool $escape = null)
     {
+        $qbOrderBy = [];
         if (empty($orderBy)) {
             return $this;
         }

system/Database/SQLSRV/Connection.php

@@ -529,6 +529,7 @@ public function getPlatform(): string
      */
     public function getVersion(): string
     {
+        $info = [];
         if (isset($this->dataCache['version'])) {
             return $this->dataCache['version'];
         }

system/Debug/Toolbar.php

@@ -76,6 +76,7 @@ public function __construct(ToolbarConfig $config)
      */
     public function run(float $startTime, float $totalTime, RequestInterface $request, ResponseInterface $response): string
     {
+        $data = [];
         // Data items used within the view.
         $data['url']             = current_url();
         $data['method']          = strtoupper($request->getMethod());

system/Debug/Toolbar/Collectors/Database.php

@@ -140,6 +140,7 @@ protected function formatTimelineData(): array
      */
     public function display(): array
     {
+        $data            = [];
         $data['queries'] = array_map(static function (array $query) {
             $isDuplicate = $query['duplicate'] === true;