fix: deprecated code in PHP 8.3

kenjis · kenjis · commit 436457338c66 · 2023-09-08T10:17:23.000+09:00
Calling ReflectionProperty::setValue() with a 1st argument which is not null or an object is deprecated
diff --git a/system/Test/ReflectionHelper.php b/system/Test/ReflectionHelper.php
@@ -74,7 +74,12 @@ private static function getAccessibleRefProperty($obj, $property)
     public static function setPrivateProperty($obj, $property, $value)
     {
         $refProperty = self::getAccessibleRefProperty($obj, $property);
-        $refProperty->setValue($obj, $value);
+
+        if (is_object($obj)) {
+            $refProperty->setValue($obj, $value);
+        } else {
+            $refProperty->setValue(null, $value);
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,12 @@ private static function getAccessibleRefProperty($obj, $property)`
`74`	`74`	`public static function setPrivateProperty($obj, $property, $value)`
`75`	`75`	`{`
`76`	`76`	`$refProperty = self::getAccessibleRefProperty($obj, $property);`
`77`		`- $refProperty->setValue($obj, $value);`
	`77`	`+`
	`78`	`+ if (is_object($obj)) {`
	`79`	`+ $refProperty->setValue($obj, $value);`
	`80`	`+ } else {`
	`81`	`+ $refProperty->setValue(null, $value);`
	`82`	`+ }`
`78`	`83`	`}`
`79`	`84`
`80`	`85`	`/**`